From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 5D68C1FF09B for ; Mon, 09 Nov 2026 09:29:40 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B7D1E214DD; Mon, 09 Nov 2026 09:29:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mail01.blue3.com.br 48FAE1ED46 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blue3.com.br; s=74B2153C-A346-11F1-819A-80A2F9424CE8; t=1794080315; bh=pUs41txyQtJhldYLr90iCnDrCHsiEaYH/WH4PUokg/8=; h=Date:From:To:Message-ID:MIME-Version; b=f3NVbgZ1J2jqsbfE0/+/x7wnWHnQg0H+abe1f1VmyOKqTtmgDDojdUWMdexaAPzyN qk9If+wYRXn2Xas+cI1lxUgrEekVVBwMRN6APTyNIEVkRz3sMtmi6MoikemtS88BGM pf0niJW9W+6t+/FlfwHeVYadWdbcemBIXShMQq0Pis0jB8PNHIVGMbyADoqk9RCjWW 5uC+L+ayOu3z/NJwYyx/JrjMwBhtz6JDQZ83DAW2zIR7dQZBFzYMZW+hv8BE43gTXo Zzd/aikbl9wIpHihnXAKURZTIM97mCnQe8Z6Z0+C9kJ8bmXBQ6HppwIZSz+UFO79dl XKG4X8elu6kAw== X-Virus-Scanned: amavis at blue3.com.br Date: Sat, 7 Nov 2026 16:38:34 -0300 (BRT) From: Samir Hanna Verza To: pve-devel@lists.proxmox.com Message-ID: <721357310.573514.1794080314288.JavaMail.zextras@blue3.com.br> Subject: [PATCH manager] ui: backup storage selector: match complete node names MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [170.233.230.254] X-Mailer: Carbonio 4.36.6_ZEXTRAS_202610 (CarbonioWebClient - Brave 156.0.0.0 (Mac OS)/4.36.6_ZEXTRAS_202610 carbonio 202610 FOSS) Thread-Index: vORB6i9W/PyzHCNIso2NcSe2D9pojw== Thread-Topic: backup storage selector: match complete node names X-SPAM-LEVEL: Spam detection results: 0 DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-MailFrom: samir@blue3.com.br X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: H5FLR7ZKU3GCSDONKZXR7454J54ZH67F X-Message-ID-Hash: H5FLR7ZKU3GCSDONKZXR7454J54ZH67F X-Mailman-Approved-At: Mon, 09 Nov 2026 09:29:17 +0100 X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The cluster-wide storage endpoint returns a comma-separated node list. Checking it as a string makes a storage restricted to pve10 appear in the backup storage picker for pve1. The job cannot activate that storage when it runs on pve1. Split the list before testing membership. Keep unrestricted storages and the existing content and disabled filters. The selector fixture fails on the prefix and suffix cases before this change. It passes for exact names, multi-node lists, and All nodes afterward. The fixture uses the production selector methods and a mocked store. Bugzilla: https://bugzilla.proxmox.com/show_bug.cgi?id=8303 Signed-off-by: Samir Hanna Verza --- www/manager6/form/StorageSelector.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/www/manager6/form/StorageSelector.js b/www/manager6/form/StorageSelector.js index 0b5e10da..bcf0bb05 100644 --- a/www/manager6/form/StorageSelector.js +++ b/www/manager6/form/StorageSelector.js @@ -87,10 +87,10 @@ Ext.define( } if (me.nodename) { - filters.push( - (storage) => - !storage.data.nodes || storage.data.nodes.includes(me.nodename), - ); + filters.push((storage) => { + let nodes = storage.data.nodes; + return !nodes || nodes.split(',').includes(me.nodename); + }); } me.getStore().clearFilter(); base-commit: a5355c34dea5e9b1d616788a150f08f3a520a575