public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Samir Hanna Verza <samir@blue3.com.br>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager] ui: backup storage selector: match complete node names
Date: Sat, 7 Nov 2026 16:38:34 -0300 (BRT)	[thread overview]
Message-ID: <721357310.573514.1794080314288.JavaMail.zextras@blue3.com.br> (raw)

The cluster-wide storage endpoint returns a comma-separated node list.
Checking it as a string makes a storage restricted to pve10 appear in
the backup storage picker for pve1. The job cannot activate that
storage when it runs on pve1.

Split the list before testing membership. Keep unrestricted storages
and the existing content and disabled filters.

The selector fixture fails on the prefix and suffix cases before this
change. It passes for exact names, multi-node lists, and All nodes
afterward. The fixture uses the production selector methods and a
mocked store.

Bugzilla: https://bugzilla.proxmox.com/show_bug.cgi?id=8303
Signed-off-by: Samir Hanna Verza <samir@blue3.com.br>
---
 www/manager6/form/StorageSelector.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/manager6/form/StorageSelector.js b/www/manager6/form/StorageSelector.js
index 0b5e10da..bcf0bb05 100644
--- a/www/manager6/form/StorageSelector.js
+++ b/www/manager6/form/StorageSelector.js
@@ -87,10 +87,10 @@ Ext.define(
                 }
 
                 if (me.nodename) {
-                    filters.push(
-                        (storage) =>
-                            !storage.data.nodes || storage.data.nodes.includes(me.nodename),
-                    );
+                    filters.push((storage) => {
+                        let nodes = storage.data.nodes;
+                        return !nodes || nodes.split(',').includes(me.nodename);
+                    });
                 }
 
                 me.getStore().clearFilter();

base-commit: a5355c34dea5e9b1d616788a150f08f3a520a575



                 reply	other threads:[~2026-11-09  8:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=721357310.573514.1794080314288.JavaMail.zextras@blue3.com.br \
    --to=samir@blue3.com.br \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal