public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Mira Limbeck <m.limbeck@proxmox.com>,
	Dietmar Maurer <dietmar@proxmox.com>,
	pve-devel@lists.proxmox.com
Subject: Re: [PATCH v2 storage 02/15] mapping: add base plugin
Date: Wed, 15 Jul 2026 13:03:11 +0200	[thread overview]
Message-ID: <3a2cf26c-4c86-4e2c-8cc3-b4fe004d6ee1@proxmox.com> (raw)
In-Reply-To: <e72ee42b-aeab-4a2c-9002-e2dbee85ccb4@proxmox.com>

Am 15.07.26 um 12:44 schrieb Mira Limbeck:
> The inspiration to write it as a plugin on top of the current storage
> plugins mostly came from the PCI and USB mapping plugins we already had.

FWIW, the main two use case and rationale to have the mappings for them are:
1. Allow declaring with devices can be used for a VM to allow migration to
   other nodes.
2. Allow to pass out ACLs to such devices cleanly so that non-root users
   can use them too.

If we want/need to support both points, for storage mappings too, then the
resource mappings are a better fit.
If that's not needed  for all relevant use cases we want to care about, then
a storage mapping is indeed simpler.
Without thinking this through that deeply, the storage mapping case probably
does not needs point 2, as storages themselves already have first-class support
in the permission system. And just for the map itself - without the need for
the mappings ACL infrastructure - they are rather overkill. So a per storage
map is probably the better choice.

btw. Wolfgang is checking out improving and leveraging the oneOf support of
our schema to make the storage plugins use that with a mechanism to expose
relevant (common) properties for external plugins for backward compat while
making the schema basically work like it would then work in rust.
While that might take a bit of time, a new property - like Dietmar's proposed
"map" doesn't makes this really harder to do, so I'd not care to much for it.





  reply	other threads:[~2026-07-15 11:03 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 17:26 [PATCH v2 cluster/storage/manager 00/15] storage mapping Mira Limbeck
2026-04-30 17:26 ` [PATCH v2 cluster 01/15] mapping: add storage.cfg Mira Limbeck
2026-04-30 17:27 ` [PATCH v2 storage 02/15] mapping: add base plugin Mira Limbeck
2026-04-30 17:35   ` Mira Limbeck
2026-05-23 21:26   ` Thomas Lamprecht
2026-07-13  9:54   ` Dietmar Maurer
2026-07-15 10:43     ` Mira Limbeck
2026-07-15 11:03       ` Thomas Lamprecht [this message]
2026-04-30 17:27 ` [PATCH v2 storage 03/15] mapping: add iSCSI plugin Mira Limbeck
2026-04-30 17:27 ` [PATCH v2 storage 04/15] iscsi: introduce mapping support Mira Limbeck
2026-07-13  9:19   ` Dietmar Maurer
2026-07-15 10:39     ` Mira Limbeck
2026-04-30 17:27 ` [PATCH v2 storage 05/15] iscsi: add helper to get local config Mira Limbeck
2026-05-23 21:26   ` Thomas Lamprecht
2026-04-30 17:27 ` [PATCH v2 storage 06/15] iscsi: change functions to handle mappings Mira Limbeck
2026-05-23 21:26   ` Thomas Lamprecht
2026-04-30 17:27 ` [PATCH v2 storage 07/15] iscsi: introduce helper to update discovery db Mira Limbeck
2026-05-11 16:46   ` Samuel Rufinatscha
2026-05-23 21:26   ` Thomas Lamprecht
2026-04-30 17:27 ` [PATCH v2 storage 08/15] iscsi: rework to update discovery db and simplify login Mira Limbeck
2026-05-23 21:26   ` Thomas Lamprecht
2026-05-26  8:42     ` Mira Limbeck
2026-04-30 17:27 ` [PATCH v2 storage 09/15] iscsi: remove stale sessions in non-mapping case Mira Limbeck
2026-05-23 21:26   ` Thomas Lamprecht
2026-05-26  8:48     ` Mira Limbeck
2026-04-30 17:27 ` [PATCH v2 storage 10/15] api: add mapping support Mira Limbeck
2026-05-23 21:26   ` Thomas Lamprecht
2026-04-30 17:27 ` [PATCH v2 storage 11/15] mapping: iscsi: add discovery-portal config option Mira Limbeck
2026-04-30 17:27 ` [PATCH v2 storage 12/15] iscsi: add support for non-persistent discovery Mira Limbeck
2026-04-30 17:38   ` Mira Limbeck
2026-05-23 21:26   ` Thomas Lamprecht
2026-05-26  8:36     ` Mira Limbeck
2026-04-30 17:27 ` [PATCH v2 storage 13/15] api: add non-persistent iscsi discovery option Mira Limbeck
2026-05-23 21:26   ` Thomas Lamprecht
2026-04-30 17:27 ` [POC v2 storage 14/15] mapping: add zfspool plugin Mira Limbeck
2026-05-23 21:26   ` Thomas Lamprecht
2026-04-30 17:27 ` [PATCH v2 manager 15/15] api: mapping: add storage mapping path Mira Limbeck
2026-05-11 17:05 ` [PATCH v2 cluster/storage/manager 00/15] storage mapping Samuel Rufinatscha
2026-05-23 21:26 ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a2cf26c-4c86-4e2c-8cc3-b4fe004d6ee1@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=dietmar@proxmox.com \
    --cc=m.limbeck@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal