From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Mira Limbeck <m.limbeck@proxmox.com>
Subject: Re: [PATCH v2 storage 02/15] mapping: add base plugin
Date: Sat, 23 May 2026 23:26:07 +0200 [thread overview]
Message-ID: <20260523212856.2822353-2-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20260430173220.441001-3-m.limbeck@proxmox.com>
Missing Signed-off-by: on this patch (the other 14 have one).
On Thu, 30 Apr 2026 19:27:00 +0200, Mira Limbeck wrote:
> diff --git a/src/PVE/Storage/Mapping.pm b/src/PVE/Storage/Mapping.pm
> @@ -0,0 +1,44 @@
> + if ($entry && $entry->{node} eq $nodename) {
> + push $res->@*, $entry;
Filtering on node is exactly right for iSCSI, so nothing to change here - just
noting for the future multipath angle from the cover: a node-invariant resource
(a WWID) would want one cluster-wide entry rather than a `map` line per node, so
leaving room for a non-node-filtered lookup here would help then.
next prev parent reply other threads:[~2026-05-23 21:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 17:26 [PATCH v2 cluster/storage/manager 00/15] storage mapping Mira Limbeck
2026-04-30 17:26 ` [PATCH v2 cluster 01/15] mapping: add storage.cfg Mira Limbeck
2026-04-30 17:27 ` [PATCH v2 storage 02/15] mapping: add base plugin Mira Limbeck
2026-04-30 17:35 ` Mira Limbeck
2026-05-23 21:26 ` Thomas Lamprecht [this message]
2026-04-30 17:27 ` [PATCH v2 storage 03/15] mapping: add iSCSI plugin Mira Limbeck
2026-04-30 17:27 ` [PATCH v2 storage 04/15] iscsi: introduce mapping support Mira Limbeck
2026-04-30 17:27 ` [PATCH v2 storage 05/15] iscsi: add helper to get local config Mira Limbeck
2026-05-23 21:26 ` Thomas Lamprecht
2026-04-30 17:27 ` [PATCH v2 storage 06/15] iscsi: change functions to handle mappings Mira Limbeck
2026-05-23 21:26 ` Thomas Lamprecht
2026-04-30 17:27 ` [PATCH v2 storage 07/15] iscsi: introduce helper to update discovery db Mira Limbeck
2026-05-11 16:46 ` Samuel Rufinatscha
2026-05-23 21:26 ` Thomas Lamprecht
2026-04-30 17:27 ` [PATCH v2 storage 08/15] iscsi: rework to update discovery db and simplify login Mira Limbeck
2026-05-23 21:26 ` Thomas Lamprecht
2026-04-30 17:27 ` [PATCH v2 storage 09/15] iscsi: remove stale sessions in non-mapping case Mira Limbeck
2026-05-23 21:26 ` Thomas Lamprecht
2026-04-30 17:27 ` [PATCH v2 storage 10/15] api: add mapping support Mira Limbeck
2026-05-23 21:26 ` Thomas Lamprecht
2026-04-30 17:27 ` [PATCH v2 storage 11/15] mapping: iscsi: add discovery-portal config option Mira Limbeck
2026-04-30 17:27 ` [PATCH v2 storage 12/15] iscsi: add support for non-persistent discovery Mira Limbeck
2026-04-30 17:38 ` Mira Limbeck
2026-05-23 21:26 ` Thomas Lamprecht
2026-04-30 17:27 ` [PATCH v2 storage 13/15] api: add non-persistent iscsi discovery option Mira Limbeck
2026-05-23 21:26 ` Thomas Lamprecht
2026-04-30 17:27 ` [POC v2 storage 14/15] mapping: add zfspool plugin Mira Limbeck
2026-05-23 21:26 ` Thomas Lamprecht
2026-04-30 17:27 ` [PATCH v2 manager 15/15] api: mapping: add storage mapping path Mira Limbeck
2026-05-11 17:05 ` [PATCH v2 cluster/storage/manager 00/15] storage mapping Samuel Rufinatscha
2026-05-23 21:26 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260523212856.2822353-2-t.lamprecht@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox