[PATCH v2 storage 09/15] iscsi: remove stale sessions in non-mapping case

[Mira Limbeck <m.limbeck@proxmox.com>]

So far there was no cleanup for sessions of target/portal combinations
that are no longer exported.
Adds a cleanup after all logins are done or sessions are rescanned.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
---
This patch is optional and may be a bit controversial since it changes
the current behavior.

This patch should be discussed in-depth before it is applied.

 src/PVE/Storage/ISCSIPlugin.pm | 35 ++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/src/PVE/Storage/ISCSIPlugin.pm b/src/PVE/Storage/ISCSIPlugin.pm
index b3f4e60..5b636a8 100644
--- a/src/PVE/Storage/ISCSIPlugin.pm
+++ b/src/PVE/Storage/ISCSIPlugin.pm
@@ -736,6 +736,41 @@ sub activate_storage {
             iscsi_session_rescan($targets->{$target}->{sessions});
         }
     }
+
+    # log out of stale sessions
+    # should only be needed for the non-mapping case
+    if (!$local_cfg->{is_mapping}) {
+        for my $target (keys $targets->%*) {
+            for my $session ($targets->{$target}->{sessions}->@*) {
+                my $portals = $targets->{$target}->{portals};
+                if (!grep(/^\Q$session->{portal}\E$/, $portals->@*)) {
+                    my $sid = $session->{session_id};
+                    my $portal = $session->{portal};
+                    print "logging out of stale iscsi session: $sid for $target via $portal\n";
+                    my $cmd = [
+                        $ISCSIADM, '--mode', 'session', '--sid', $sid, '--logout',
+                    ];
+                    eval { run_command($cmd); };
+                    warn "failed to log out of stale session: $@\n" if $@;
+
+                    print "removing stale node entry: $target via $portal\n";
+                    $cmd = [
+                        $ISCSIADM,
+                        '--mode',
+                        'node',
+                        '--target',
+                        $target,
+                        '--portal',
+                        $portal,
+                        '-o',
+                        'delete',
+                    ];
+                    eval { run_command($cmd); };
+                    warn "failed to remove stale node entry: $@\n" if $@;
+                }
+            }
+        }
+    }
 }
 
 sub deactivate_storage {
-- 
2.47.3