Re: [PATCH v2 storage 13/15] api: add non-persistent iscsi discovery option

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On Thu, 30 Apr 2026 19:27:11 +0200, Mira Limbeck wrote:
> diff --git a/src/PVE/API2/Storage/Scan.pm b/src/PVE/API2/Storage/Scan.pm
> @@ -280,17 +286,39 @@ __PACKAGE__->register_method({
>          my $data = [];
>          foreach my $k (sort keys %$res) {
> -            push @$data, { target => $k, portal => join(',', @{ $res->{$k} }) };
> +            my $portals = [];
> +            my $portals_reachability = [];
> +            for my $entry ($res->{$k}->@*) {
> +                my $portal = $entry->{portal};
> +                my $reachability = $entry->{reachable} ? '1' : '0';
> +                push $portals->@*, $portal;
> +                push $portals_reachability->@*, $portal . ':' . $reachability;
> +            }
> +            #my $portals = [ map { $_->{portal} } $res->{$k}->@* ];
> +            #my $portals_reachability = [ map { $_->{portal} . ':' . ($_->{reachable} ? '1' : '0') } $res->{$k}->@* ];
> +            my $entry = {
> +                target => $k,
> +                portal => join(',', $portals->@*),
> +                portals => join(',', $portals_reachability->@*),
> +                #portals => join(',', map { $_->{portal}.':'.($_->{reachable} // '0') } $res->{$k}->@*),
> +            };
> +            #push @$data, { target => $k, portal => join(',', $portals->@*) };
> +            push $data->@*, $entry;
>          }

Leftover commented-out lines above, drop before merge.

Also: iscsi_discovery's 4th arg is renamed $update_db (12/15) -> $persist
(13/15); fine once applied in order, just confirm the final name and that
scan_iscsi's trailing 0 means "do not persist".