public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Jonas Theisen <j.theisen@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 06/15] migrate: warn about live migration of host CPU VMs between CPU models
Date: Wed, 18 Nov 2026 16:40:37 +0100	[thread overview]
Message-ID: <20261118154207.424260-7-j.theisen@proxmox.com> (raw)
In-Reply-To: <20261118154207.424260-1-j.theisen@proxmox.com>

Even if the target node's CPU supports all flags of the source node's
CPU, a guest with the 'host' or 'max' CPU model can run into problems
after a live migration between different physical CPU models, as they
can still behave differently, for example regarding errata. The
documentation advises against this setup for that reason.

Broadcast the CPU model name as part of the node's CPU information and
warn if it differs between the source and the target node.

Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
 src/PVE/API2/Qemu.pm               |  2 +-
 src/PVE/QemuMigrate/Helpers.pm     | 23 ++++++++++++++
 src/PVE/QemuServer/Helpers.pm      |  3 ++
 src/test/run_qemu_migrate_tests.pl | 49 ++++++++++++++++++++++++++++++
 4 files changed, 76 insertions(+), 1 deletion(-)

diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index aaaa8760..f55cb641 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -5631,7 +5631,7 @@ __PACKAGE__->register_method({
                             type => {
                                 type => 'string',
                                 description => "The check that reported the warning.",
-                                enum => ['cpu-vendor', 'missing-cpu-info'],
+                                enum => ['cpu-vendor', 'missing-cpu-info', 'host-cpu-model'],
                             },
                             message => {
                                 type => 'string',
diff --git a/src/PVE/QemuMigrate/Helpers.pm b/src/PVE/QemuMigrate/Helpers.pm
index b13992d1..0a0f3787 100644
--- a/src/PVE/QemuMigrate/Helpers.pm
+++ b/src/PVE/QemuMigrate/Helpers.pm
@@ -264,6 +264,29 @@ my $target_cpu_checks = [
                 . format_flag_list(\@missing);
         },
     },
+    {
+        type => 'host-cpu-model',
+        severity => 'warning',
+        needs => ['model-name'],
+        applies => sub {
+            my ($cpu) = @_;
+            return is_host_cpu_model($cpu);
+        },
+        check => sub {
+            my ($cpu, $source, $target) = @_;
+
+            # already reported by the 'cpu-vendor' check
+            return if vendors_differ($source, $target);
+
+            my ($source_model, $target_model) =
+                ($source->{'model-name'}, $target->{'model-name'});
+            return if !defined($source_model) || $source_model eq $target_model;
+
+            # same flags do not imply the same behavior, for example regarding errata
+            return "CPU model '$cpu->{model}' is only reliable for live migration between"
+                . " identical CPUs, but the node has '$target_model' instead of '$source_model'";
+        },
+    },
 ];
 
 # Returns the issues of the target node, and whether all checks that can prevent the migration
diff --git a/src/PVE/QemuServer/Helpers.pm b/src/PVE/QemuServer/Helpers.pm
index 14f822cc..3932eb12 100644
--- a/src/PVE/QemuServer/Helpers.pm
+++ b/src/PVE/QemuServer/Helpers.pm
@@ -371,6 +371,8 @@ encoded as JSON. The returned hash contains:
 
 =item C<vendor>: the CPU vendor ID, for example C<GenuineIntel> or C<AuthenticAMD>
 
+=item C<model-name>: the CPU model name, for example C<AMD EPYC 7302 16-Core Processor>
+
 =back
 
 Properties that cannot be determined are missing. Consumers of the broadcast information must
@@ -386,6 +388,7 @@ sub get_host_cpu_info {
 
     my $info = {};
     $info->{vendor} = $cpuinfo->{vendor} if $known->($cpuinfo->{vendor});
+    $info->{'model-name'} = $cpuinfo->{model} if $known->($cpuinfo->{model});
 
     return $info;
 }
diff --git a/src/test/run_qemu_migrate_tests.pl b/src/test/run_qemu_migrate_tests.pl
index 0e33cfbc..50f38388 100755
--- a/src/test/run_qemu_migrate_tests.pl
+++ b/src/test/run_qemu_migrate_tests.pl
@@ -1810,6 +1810,55 @@ my $tests = [
             },
         },
     },
+    {
+        name => '1033_running_host_cpu_other_model',
+        target => 'pve1',
+        vmid => 1033,
+        vm_status => {
+            running => 1,
+            runningmachine => 'pc-q35-5.0+pve0',
+            runningcpu => 'host,+kvm_pv_eoi,+kvm_pv_unhalt',
+        },
+        cpu_info => {
+            source => {
+                vendor => 'AuthenticAMD',
+                'model-name' => 'AMD EPYC 7302 16-Core Processor',
+            },
+            nodes => {
+                pve1 => {
+                    vendor => 'AuthenticAMD',
+                    'model-name' => 'AMD EPYC 7313 16-Core Processor',
+                },
+            },
+            'kvm-flags' => {
+                pve0 => 'fpu sse',
+                pve1 => 'fpu sse',
+            },
+        },
+        opts => {
+            online => 1,
+        },
+        config_patch => {
+            cpu => 'host',
+        },
+        expected_calls => $default_expected_calls_online,
+        expect_log => [
+            "CPU of node 'pve1' might be incompatible: CPU model 'host' is only reliable for"
+                . " live migration between identical CPUs, but the node has 'AMD EPYC 7313"
+                . " 16-Core Processor' instead of 'AMD EPYC 7302 16-Core Processor'",
+        ],
+        expected => {
+            source_volids => {},
+            target_volids => {},
+            vm_config => get_patched_config(1033, {
+                    cpu => 'host',
+            }),
+            vm_status => {
+                running => 1,
+                runningmachine => 'pc-q35-5.0+pve0',
+            },
+        },
+    },
     {
         name => '105_replicated_to_non_replication_target',
         target => 'pve1',
-- 
2.47.3





  parent reply	other threads:[~2026-11-18 15:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 15:40 [PATCH manager/qemu-server 00/15] check the target node's CPU before live migrating a VM Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 01/15] test: migration: allow checking for warnings and errors in the log Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 02/15] migrate: block live migration of host CPU VMs between CPU vendors Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 03/15] fix #6535: migrate: warn about live migration " Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 04/15] cpu flags: factor out parsing the broadcast CPU flags of a node Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 05/15] fix #2924: migrate: block live migration of host CPU VMs to nodes lacking flags Jonas Theisen
2026-11-18 15:40 ` Jonas Theisen [this message]
2026-11-18 15:40 ` [PATCH qemu-server 07/15] migrate: factor out whether the running virtual CPU is kept Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 08/15] migrate: block migration if the target cannot run the kept virtual CPU Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 09/15] helpers: add helper to query the host's TSC frequency and scaling support Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 10/15] cpu config: add hv-reenlightenment flag and set TSC frequency for it Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 11/15] migrate: block migration to nodes with incompatible TSC for re-enlightenment Jonas Theisen
2026-11-18 15:40 ` [PATCH manager 12/15] pvestatd: broadcast host CPU information relevant for live migration Jonas Theisen
2026-11-18 15:40 ` [PATCH manager 13/15] ui: migrate: show why the CPU of the target node is incompatible Jonas Theisen
2026-11-18 15:40 ` [PATCH manager 14/15] fix #6535: ui: migrate: show CPU warnings for the target node Jonas Theisen
2026-11-18 15:40 ` [PATCH manager 15/15] api: nodes: migrateall: skip VMs whose CPU is incompatible with the target Jonas Theisen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118154207.424260-7-j.theisen@proxmox.com \
    --to=j.theisen@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal