From: Jonas Theisen <j.theisen@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 03/15] fix #6535: migrate: warn about live migration between CPU vendors
Date: Wed, 18 Nov 2026 16:40:34 +0100 [thread overview]
Message-ID: <20261118154207.424260-4-j.theisen@proxmox.com> (raw)
In-Reply-To: <20261118154207.424260-1-j.theisen@proxmox.com>
Live migrating a VM between nodes with CPUs from different vendors is
not guaranteed to work, even with generic CPU models that do not pass
through vendor-specific features, as the CPUs still behave differently
in some regards.
Warn about this in the migration task, as a task warning so that the
task status shows it, and report it for each node in the migration
precondition API, so that it can be shown before the migration is
started. As before, VMs with the 'host' or 'max' CPU model cannot be
live migrated between vendors at all.
Also report nodes that lack the CPU information needed for a check
that would block the migration as a warning in the precondition API,
as the task log only shows this once the migration is started. This
is not done for other checks, to not warn about every live migration
to nodes running an older version.
Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
src/PVE/API2/Qemu.pm | 42 +++++++++++++++++++++++++++---
src/PVE/QemuMigrate.pm | 9 ++++++-
src/PVE/QemuMigrate/Helpers.pm | 19 ++++++++++++++
src/test/run_qemu_migrate_tests.pl | 33 +++++++++++++++++++++++
4 files changed, 99 insertions(+), 4 deletions(-)
diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index 0210dd1c..9d7fcf8b 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -5604,6 +5604,29 @@ __PACKAGE__->register_method({
description =>
"Object of mapped resources with additional information such if they're live migratable.",
},
+ 'cpu-warnings' => {
+ type => 'object',
+ optional => 1,
+ description => "For each node, reasons why the VM might not run reliably on its"
+ . " CPU after a live migration.",
+ additionalProperties => {
+ type => 'array',
+ items => {
+ type => 'object',
+ properties => {
+ type => {
+ type => 'string',
+ description => "The check that reported the warning.",
+ enum => ['cpu-vendor', 'missing-cpu-info'],
+ },
+ message => {
+ type => 'string',
+ description => "Why the VM might not run reliably.",
+ },
+ },
+ },
+ },
+ },
'has-dbus-vmstate' => {
type => 'boolean',
description => 'Whether the VM host supports migrating additional VM state, '
@@ -5676,9 +5699,15 @@ __PACKAGE__->register_method({
my $cpu_issues_by_node = eval {
my $targets = [grep { $_ ne $localnode } $nodelist->@*];
- my ($issues) = PVE::QemuMigrate::Helpers::check_target_cpu_compatibility(
- $vmconf, $pid, $targets,
- );
+ my ($issues, $unchecked_nodes) =
+ PVE::QemuMigrate::Helpers::check_target_cpu_compatibility($vmconf, $pid, $targets);
+ my $message = "the node does not provide CPU information, for example as it runs"
+ . " an older version";
+ for my $node ($unchecked_nodes->@*) {
+ my $issue =
+ { type => 'missing-cpu-info', severity => 'warning', message => $message };
+ push $issues->{$node}->@*, $issue;
+ }
return $issues;
} // {};
warn "unable to check CPU compatibility of target nodes - $@" if $@;
@@ -5705,6 +5734,13 @@ __PACKAGE__->register_method({
[map { { type => $_->{type}, message => $_->{message} } } @cpu_errors];
}
+ my @cpu_warnings =
+ grep { $_->{severity} eq 'warning' } ($cpu_issues_by_node->{$node} // [])->@*;
+ if (scalar(@cpu_warnings)) {
+ $res->{'cpu-warnings'}->{$node} =
+ [map { { type => $_->{type}, message => $_->{message} } } @cpu_warnings];
+ }
+
# extracting blocking resources for current node
if (my $blocking_ha_resources = $blocking_ha_resources_by_node->{$node}) {
$res->{not_allowed_nodes}->{$node}->{'blocking-ha-resources'} =
diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm
index cf01b2eb..827f8143 100644
--- a/src/PVE/QemuMigrate.pm
+++ b/src/PVE/QemuMigrate.pm
@@ -322,7 +322,14 @@ sub prepare {
my ($cpu_issues, $unchecked_nodes) =
PVE::QemuMigrate::Helpers::check_target_cpu_compatibility($conf, $running, [$node]);
- my @errors = grep { $_->{severity} eq 'error' } ($cpu_issues->{$node} // [])->@*;
+ my @errors;
+ for my $issue (($cpu_issues->{$node} // [])->@*) {
+ if ($issue->{severity} eq 'warning') {
+ log_warn("CPU of node '$node' might be incompatible: $issue->{message}");
+ } else {
+ push @errors, $issue;
+ }
+ }
if (scalar(@errors)) {
die "can't migrate VM to '$node' - incompatible CPU: "
. join('; ', map { $_->{message} } @errors) . "\n";
diff --git a/src/PVE/QemuMigrate/Helpers.pm b/src/PVE/QemuMigrate/Helpers.pm
index f4f15b96..4e4e3ae0 100644
--- a/src/PVE/QemuMigrate/Helpers.pm
+++ b/src/PVE/QemuMigrate/Helpers.pm
@@ -187,6 +187,25 @@ my $target_cpu_checks = [
. " node ($source->{vendor}), but the node has $target->{vendor}";
},
},
+ {
+ type => 'cpu-vendor',
+ severity => 'warning',
+ needs => ['vendor'],
+ applies => sub {
+ my ($cpu) = @_;
+ return $cpu->{kvm} && !is_host_cpu_model($cpu);
+ },
+ check => sub {
+ my ($cpu, $source, $target) = @_;
+
+ return if !vendors_differ($source, $target);
+
+ # even generic CPU models expose behavior that differs between vendors
+ return
+ "live migration from $source->{vendor} to $target->{vendor} is not guaranteed"
+ . " to work, as guests can become unstable, even some time after the migration";
+ },
+ },
];
# Returns the issues of the target node, and whether all checks that can prevent the migration
diff --git a/src/test/run_qemu_migrate_tests.pl b/src/test/run_qemu_migrate_tests.pl
index 1084123b..12ec3e90 100755
--- a/src/test/run_qemu_migrate_tests.pl
+++ b/src/test/run_qemu_migrate_tests.pl
@@ -1567,6 +1567,39 @@ my $tests = [
},
},
},
+ {
+ name => '1033_running_kvm64_cpu_other_vendor',
+ target => 'pve1',
+ vmid => 1033,
+ vm_status => {
+ running => 1,
+ runningmachine => 'pc-q35-5.0+pve0',
+ runningcpu => 'kvm64,enforce,+kvm_pv_eoi,+kvm_pv_unhalt,+lahf_lm,+sep',
+ },
+ cpu_info => {
+ source => { vendor => 'AuthenticAMD' },
+ nodes => {
+ pve1 => { vendor => 'GenuineIntel' },
+ },
+ },
+ opts => {
+ online => 1,
+ },
+ expected_calls => $default_expected_calls_online,
+ expect_log => [
+ "CPU of node 'pve1' might be incompatible: live migration from AuthenticAMD to"
+ . " GenuineIntel is not guaranteed to work",
+ ],
+ expected => {
+ source_volids => {},
+ target_volids => {},
+ vm_config => $vm_configs->{1033},
+ vm_status => {
+ running => 1,
+ runningmachine => 'pc-q35-5.0+pve0',
+ },
+ },
+ },
{
name => '105_replicated_to_non_replication_target',
target => 'pve1',
--
2.47.3
next prev parent reply other threads:[~2026-11-18 15:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 15:40 [PATCH manager/qemu-server 00/15] check the target node's CPU before live migrating a VM Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 01/15] test: migration: allow checking for warnings and errors in the log Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 02/15] migrate: block live migration of host CPU VMs between CPU vendors Jonas Theisen
2026-11-18 15:40 ` Jonas Theisen [this message]
2026-11-18 15:40 ` [PATCH qemu-server 04/15] cpu flags: factor out parsing the broadcast CPU flags of a node Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 05/15] fix #2924: migrate: block live migration of host CPU VMs to nodes lacking flags Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 06/15] migrate: warn about live migration of host CPU VMs between CPU models Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 07/15] migrate: factor out whether the running virtual CPU is kept Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 08/15] migrate: block migration if the target cannot run the kept virtual CPU Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 09/15] helpers: add helper to query the host's TSC frequency and scaling support Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 10/15] cpu config: add hv-reenlightenment flag and set TSC frequency for it Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 11/15] migrate: block migration to nodes with incompatible TSC for re-enlightenment Jonas Theisen
2026-11-18 15:40 ` [PATCH manager 12/15] pvestatd: broadcast host CPU information relevant for live migration Jonas Theisen
2026-11-18 15:40 ` [PATCH manager 13/15] ui: migrate: show why the CPU of the target node is incompatible Jonas Theisen
2026-11-18 15:40 ` [PATCH manager 14/15] fix #6535: ui: migrate: show CPU warnings for the target node Jonas Theisen
2026-11-18 15:40 ` [PATCH manager 15/15] api: nodes: migrateall: skip VMs whose CPU is incompatible with the target Jonas Theisen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118154207.424260-4-j.theisen@proxmox.com \
--to=j.theisen@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox