From: Jonas Theisen <j.theisen@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 13/15] ui: migrate: show why the CPU of the target node is incompatible
Date: Wed, 18 Nov 2026 16:40:44 +0100 [thread overview]
Message-ID: <20261118154207.424260-14-j.theisen@proxmox.com> (raw)
In-Reply-To: <20261118154207.424260-1-j.theisen@proxmox.com>
Show the reasons the migration precondition API reports for target
nodes whose CPU cannot run a VM after a live migration, instead of
only failing once the migration task runs.
If root can override all of these reasons with migration options, offer
a checkbox to ignore the incompatibility, which sets these options and
shows the reasons as warnings instead. Which options to set is taken
from the API, so that further overridable checks need no UI changes.
The checkbox is also shown for HA-managed VMs, as the migration API
forwards the override options to the HA stack.
Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
www/manager6/window/Migrate.js | 54 ++++++++++++++++++++++++++++++++++
1 file changed, 54 insertions(+)
diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index 15ce34f8..68d93a6f 100644
--- a/www/manager6/window/Migrate.js
+++ b/www/manager6/window/Migrate.js
@@ -29,6 +29,8 @@ Ext.define('PVE.window.Migrate', {
allowedNodes: undefined,
overwriteLocalResourceCheck: false,
hasLocalResources: false,
+ ignoreCpuIncompatibility: false,
+ cpuOverrides: [],
withConntrackState: true,
bothHaveDbusVmstate: false,
configCheck: true,
@@ -64,6 +66,7 @@ Ext.define('PVE.window.Migrate', {
return false;
}
},
+ cpuOverrideCheckboxHidden: (get) => !get('migration.cpuOverrides').length,
conntrackStateCheckboxHidden: (get) =>
!get('running') ||
get('vmtype') !== 'qemu' ||
@@ -147,6 +150,12 @@ Ext.define('PVE.window.Migrate', {
params.force = 1;
}
+ if (vm.get('migration.ignoreCpuIncompatibility')) {
+ for (const override of vm.get('migration.cpuOverrides')) {
+ params[override] = 1;
+ }
+ }
+
if (vm.get('migration.bothHaveDbusVmstate') && vm.get('migration.withConntrackState')) {
params['with-conntrack-state'] = 1;
}
@@ -306,6 +315,30 @@ Ext.define('PVE.window.Migrate', {
migration.preconditions.push({ text, severity: 'error' });
}
+ let cpuBlockers = disallowed['incompatible-cpu'] ?? [];
+ // the override options are reserved for root
+ let canOverrideCpu =
+ Proxmox.UserName === 'root@pam' &&
+ cpuBlockers.length > 0 &&
+ cpuBlockers.every((blocker) => blocker.override);
+ migration.cpuOverrides = canOverrideCpu
+ ? [...new Set(cpuBlockers.map((blocker) => blocker.override))]
+ : [];
+
+ for (const cpuBlocker of cpuBlockers) {
+ const text = Ext.String.format(
+ gettext('CPU of selected target is incompatible: {0}'),
+ cpuBlocker.message,
+ );
+
+ if (canOverrideCpu && migration.ignoreCpuIncompatibility) {
+ migration.preconditions.push({ text, severity: 'warning' });
+ } else {
+ migration.possible = false;
+ migration.preconditions.push({ text, severity: 'error' });
+ }
+ }
+
let blockingResources = [];
let mappedResources = migrateStats['mapped-resource-info'] ?? {};
@@ -695,6 +728,27 @@ Ext.define('PVE.window.Migrate', {
},
},
},
+ {
+ xtype: 'proxmoxcheckbox',
+ name: 'ignoreCpuIncompatibility',
+ fieldLabel: gettext('Ignore CPU incompatibility'),
+ autoEl: {
+ tag: 'div',
+ 'data-qtip': gettext(
+ 'Migrate even if the CPU of the selected target is incompatible. The VM might crash or fail to migrate.',
+ ),
+ },
+ bind: {
+ hidden: '{cpuOverrideCheckboxHidden}',
+ value: '{migration.ignoreCpuIncompatibility}',
+ },
+ listeners: {
+ change: {
+ fn: 'checkMigratePreconditions',
+ extraArg: true,
+ },
+ },
+ },
{
xtype: 'proxmoxcheckbox',
name: 'withConntrackState',
--
2.47.3
next prev parent reply other threads:[~2026-11-18 15:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 15:40 [PATCH manager/qemu-server 00/15] check the target node's CPU before live migrating a VM Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 01/15] test: migration: allow checking for warnings and errors in the log Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 02/15] migrate: block live migration of host CPU VMs between CPU vendors Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 03/15] fix #6535: migrate: warn about live migration " Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 04/15] cpu flags: factor out parsing the broadcast CPU flags of a node Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 05/15] fix #2924: migrate: block live migration of host CPU VMs to nodes lacking flags Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 06/15] migrate: warn about live migration of host CPU VMs between CPU models Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 07/15] migrate: factor out whether the running virtual CPU is kept Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 08/15] migrate: block migration if the target cannot run the kept virtual CPU Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 09/15] helpers: add helper to query the host's TSC frequency and scaling support Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 10/15] cpu config: add hv-reenlightenment flag and set TSC frequency for it Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 11/15] migrate: block migration to nodes with incompatible TSC for re-enlightenment Jonas Theisen
2026-11-18 15:40 ` [PATCH manager 12/15] pvestatd: broadcast host CPU information relevant for live migration Jonas Theisen
2026-11-18 15:40 ` Jonas Theisen [this message]
2026-11-18 15:40 ` [PATCH manager 14/15] fix #6535: ui: migrate: show CPU warnings for the target node Jonas Theisen
2026-11-18 15:40 ` [PATCH manager 15/15] api: nodes: migrateall: skip VMs whose CPU is incompatible with the target Jonas Theisen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118154207.424260-14-j.theisen@proxmox.com \
--to=j.theisen@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox