From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 7714E1FF0C0 for ; Wed, 18 Nov 2026 16:43:56 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9733C217EB; Wed, 18 Nov 2026 16:42:47 +0100 (CET) From: Jonas Theisen To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 06/15] migrate: warn about live migration of host CPU VMs between CPU models Date: Wed, 18 Nov 2026 16:40:37 +0100 Message-ID: <20261118154207.424260-7-j.theisen@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118154207.424260-1-j.theisen@proxmox.com> References: <20261118154207.424260-1-j.theisen@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795016551110 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.088 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CY6TUWRBBTA56RLLF6E44H76R2M6CBYX X-Message-ID-Hash: CY6TUWRBBTA56RLLF6E44H76R2M6CBYX X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Even if the target node's CPU supports all flags of the source node's CPU, a guest with the 'host' or 'max' CPU model can run into problems after a live migration between different physical CPU models, as they can still behave differently, for example regarding errata. The documentation advises against this setup for that reason. Broadcast the CPU model name as part of the node's CPU information and warn if it differs between the source and the target node. Signed-off-by: Jonas Theisen --- src/PVE/API2/Qemu.pm | 2 +- src/PVE/QemuMigrate/Helpers.pm | 23 ++++++++++++++ src/PVE/QemuServer/Helpers.pm | 3 ++ src/test/run_qemu_migrate_tests.pl | 49 ++++++++++++++++++++++++++++++ 4 files changed, 76 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index aaaa8760..f55cb641 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -5631,7 +5631,7 @@ __PACKAGE__->register_method({ type => { type => 'string', description => "The check that reported the warning.", - enum => ['cpu-vendor', 'missing-cpu-info'], + enum => ['cpu-vendor', 'missing-cpu-info', 'host-cpu-model'], }, message => { type => 'string', diff --git a/src/PVE/QemuMigrate/Helpers.pm b/src/PVE/QemuMigrate/Helpers.pm index b13992d1..0a0f3787 100644 --- a/src/PVE/QemuMigrate/Helpers.pm +++ b/src/PVE/QemuMigrate/Helpers.pm @@ -264,6 +264,29 @@ my $target_cpu_checks = [ . format_flag_list(\@missing); }, }, + { + type => 'host-cpu-model', + severity => 'warning', + needs => ['model-name'], + applies => sub { + my ($cpu) = @_; + return is_host_cpu_model($cpu); + }, + check => sub { + my ($cpu, $source, $target) = @_; + + # already reported by the 'cpu-vendor' check + return if vendors_differ($source, $target); + + my ($source_model, $target_model) = + ($source->{'model-name'}, $target->{'model-name'}); + return if !defined($source_model) || $source_model eq $target_model; + + # same flags do not imply the same behavior, for example regarding errata + return "CPU model '$cpu->{model}' is only reliable for live migration between" + . " identical CPUs, but the node has '$target_model' instead of '$source_model'"; + }, + }, ]; # Returns the issues of the target node, and whether all checks that can prevent the migration diff --git a/src/PVE/QemuServer/Helpers.pm b/src/PVE/QemuServer/Helpers.pm index 14f822cc..3932eb12 100644 --- a/src/PVE/QemuServer/Helpers.pm +++ b/src/PVE/QemuServer/Helpers.pm @@ -371,6 +371,8 @@ encoded as JSON. The returned hash contains: =item C: the CPU vendor ID, for example C or C +=item C: the CPU model name, for example C + =back Properties that cannot be determined are missing. Consumers of the broadcast information must @@ -386,6 +388,7 @@ sub get_host_cpu_info { my $info = {}; $info->{vendor} = $cpuinfo->{vendor} if $known->($cpuinfo->{vendor}); + $info->{'model-name'} = $cpuinfo->{model} if $known->($cpuinfo->{model}); return $info; } diff --git a/src/test/run_qemu_migrate_tests.pl b/src/test/run_qemu_migrate_tests.pl index 0e33cfbc..50f38388 100755 --- a/src/test/run_qemu_migrate_tests.pl +++ b/src/test/run_qemu_migrate_tests.pl @@ -1810,6 +1810,55 @@ my $tests = [ }, }, }, + { + name => '1033_running_host_cpu_other_model', + target => 'pve1', + vmid => 1033, + vm_status => { + running => 1, + runningmachine => 'pc-q35-5.0+pve0', + runningcpu => 'host,+kvm_pv_eoi,+kvm_pv_unhalt', + }, + cpu_info => { + source => { + vendor => 'AuthenticAMD', + 'model-name' => 'AMD EPYC 7302 16-Core Processor', + }, + nodes => { + pve1 => { + vendor => 'AuthenticAMD', + 'model-name' => 'AMD EPYC 7313 16-Core Processor', + }, + }, + 'kvm-flags' => { + pve0 => 'fpu sse', + pve1 => 'fpu sse', + }, + }, + opts => { + online => 1, + }, + config_patch => { + cpu => 'host', + }, + expected_calls => $default_expected_calls_online, + expect_log => [ + "CPU of node 'pve1' might be incompatible: CPU model 'host' is only reliable for" + . " live migration between identical CPUs, but the node has 'AMD EPYC 7313" + . " 16-Core Processor' instead of 'AMD EPYC 7302 16-Core Processor'", + ], + expected => { + source_volids => {}, + target_volids => {}, + vm_config => get_patched_config(1033, { + cpu => 'host', + }), + vm_status => { + running => 1, + runningmachine => 'pc-q35-5.0+pve0', + }, + }, + }, { name => '105_replicated_to_non_replication_target', target => 'pve1', -- 2.47.3