public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH-SERIES qemu-server/qemu 0/3] fix #8331: snapshot: fix regression with endless loop after error
@ 2026-11-18 12:21 Fiona Ebner
  2026-11-18 12:21 ` [PATCH qemu-server 1/3] " Fiona Ebner
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Fiona Ebner @ 2026-11-18 12:21 UTC (permalink / raw)
  To: pve-devel

The loop in the 'after-unfreeze' hook phase relies on the 'bytes'
value from the result of 'query-savevm' disappearing when the
'savevm-end' command is done. This does not happen in case of an
error status currently. Use a timeout of 35 seconds instead to ensure
that the loop stays bounded.

This phase was enabled by commit 568b295c ("fix #7697: snapshot hook
name mismatch") so this is an unintended regression.

Further improve the situation by having 'query-savevm' report if
'savevm-end' is still active and qemu-server checking for that.

qemu-server:

Fiona Ebner (2):
  fix #8331: snapshot: fix regression with endless loop after error
  snapshot: directly check for savevm-end status

 src/PVE/QemuConfig.pm | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)


qemu:

Fiona Ebner (1):
  async snapshot: keep track of savevm-end status

 migration/savevm-async.c | 13 +++++++++++++
 qapi/migration.json      |  6 +++++-
 2 files changed, 18 insertions(+), 1 deletion(-)


Summary over all repositories:
  3 files changed, 30 insertions(+), 3 deletions(-)

-- 
Generated by git-murpp 0.5.0




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-18 21:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 12:21 [PATCH-SERIES qemu-server/qemu 0/3] fix #8331: snapshot: fix regression with endless loop after error Fiona Ebner
2026-11-18 12:21 ` [PATCH qemu-server 1/3] " Fiona Ebner
2026-11-18 12:21 ` [PATCH qemu-server 2/3] snapshot: directly check for savevm-end status Fiona Ebner
2026-11-18 12:21 ` [PATCH qemu 3/3] async snapshot: keep track of " Fiona Ebner
2026-11-18 21:02 ` applied: [PATCH-SERIES qemu-server/qemu 0/3] fix #8331: snapshot: fix regression with endless loop after error Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal