From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id BD2A01FF0E3 for ; Wed, 18 Nov 2026 22:02:49 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 61D9F21813; Wed, 18 Nov 2026 22:02:47 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Fiona Ebner Subject: applied: [PATCH-SERIES qemu-server/qemu 0/3] fix #8331: snapshot: fix regression with endless loop after error Date: Wed, 18 Nov 2026 22:02:35 +0100 Message-ID: <179503572796.3229840.14355964314612283138.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118122359.123647-1-f.ebner@proxmox.com> References: <20261118122359.123647-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795035762443 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.164 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: H6L2AQ46F627XQKNMJWR275AU655HEDG X-Message-ID-Hash: H6L2AQ46F627XQKNMJWR275AU655HEDG X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 18 Nov 2026 13:21:46 +0100, Fiona Ebner wrote: > The loop in the 'after-unfreeze' hook phase relies on the 'bytes' > value from the result of 'query-savevm' disappearing when the > 'savevm-end' command is done. This does not happen in case of an > error status currently. Use a timeout of 35 seconds instead to ensure > that the loop stays bounded. > > This phase was enabled by commit 568b295c ("fix #7697: snapshot hook > name mismatch") so this is an unintended regression. > > [...] Applied, thanks! [qemu-server] applied to qemu-server.git (master) [1/2] fix #8331: snapshot: fix regression with endless loop after error https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=610bd239a85f54053a2708abab5be633120abc52 [2/2] snapshot: directly check for savevm-end status https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=a906ed74688d825549dc50ec6cbce10d1cfa152e [qemu] applied to git/pve-qemu (master) [1/1] async snapshot: keep track of savevm-end status commit: 4494236f6b1da3955766707e327ba53c892284ea