public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: applied: [PATCH-SERIES qemu-server/qemu 0/3] fix #8331: snapshot: fix regression with endless loop after error
Date: Wed, 18 Nov 2026 22:02:35 +0100	[thread overview]
Message-ID: <179503572796.3229840.14355964314612283138.b4-ty@b4> (raw)
In-Reply-To: <20261118122359.123647-1-f.ebner@proxmox.com>

On Wed, 18 Nov 2026 13:21:46 +0100, Fiona Ebner wrote:
> The loop in the 'after-unfreeze' hook phase relies on the 'bytes'
> value from the result of 'query-savevm' disappearing when the
> 'savevm-end' command is done. This does not happen in case of an
> error status currently. Use a timeout of 35 seconds instead to ensure
> that the loop stays bounded.
> 
> This phase was enabled by commit 568b295c ("fix #7697: snapshot hook
> name mismatch") so this is an unintended regression.
> 
> [...]

Applied, thanks!

[qemu-server] applied to qemu-server.git (master)
[1/2] fix #8331: snapshot: fix regression with endless loop after error
      https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=610bd239a85f54053a2708abab5be633120abc52
[2/2] snapshot: directly check for savevm-end status
      https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=a906ed74688d825549dc50ec6cbce10d1cfa152e

[qemu] applied to git/pve-qemu (master)
[1/1] async snapshot: keep track of savevm-end status
      commit: 4494236f6b1da3955766707e327ba53c892284ea




      parent reply	other threads:[~2026-11-18 21:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 12:21 [PATCH-SERIES qemu-server/qemu 0/3] fix #8331: snapshot: fix regression with endless loop after error Fiona Ebner
2026-11-18 12:21 ` [PATCH qemu-server 1/3] " Fiona Ebner
2026-11-18 12:21 ` [PATCH qemu-server 2/3] snapshot: directly check for savevm-end status Fiona Ebner
2026-11-18 12:21 ` [PATCH qemu 3/3] async snapshot: keep track of " Fiona Ebner
2026-11-18 21:02 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179503572796.3229840.14355964314612283138.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal