[PATCH ha-manager 06/16] config: use early returns in parse_sid

[Daniel Kral <d.kral@proxmox.com>]

This is in preparation of an upcoming patch, which moves the conditional
vmid parsing and info-fetching branch to its separate helper subroutine.

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
 src/PVE/HA/Config.pm | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/src/PVE/HA/Config.pm b/src/PVE/HA/Config.pm
index 86574dc2..7b49534c 100644
--- a/src/PVE/HA/Config.pm
+++ b/src/PVE/HA/Config.pm
@@ -198,27 +198,21 @@ sub update_resources_config {
 sub parse_sid {
     my ($sid) = @_;
 
-    my ($type, $vmid);
-
-    if ($sid =~ m/^(\d+)$/) {
-        $vmid = $1;
-
+    if (my ($vmid) = $sid =~ m/^(\d+)$/) {
         my $vmlist = PVE::Cluster::get_vmlist();
         if (defined($vmlist->{ids}->{$vmid})) {
             my $vm_type = $vmlist->{ids}->{$vmid}->{type};
-            $type = PVE::HA::Tools::get_ha_resource_type($vm_type);
+            my $type = PVE::HA::Tools::get_ha_resource_type($vm_type);
             $sid = "$type:$vmid";
+            return ($sid, $type, $vmid);
         } else {
             die "unable to detect SID from VMID - VM/CT $1 does not exist\n";
         }
-    } elsif ($sid =~ m/^(\S+):(\S+)$/) {
-        $vmid = $2;
-        $type = $1;
+    } elsif (my ($type, $vmid) = $sid =~ m/^(\S+):(\S+)$/) {
+        return ($sid, $type, $vmid);
     } else {
         die "unable to parse service id '$sid'\n";
     }
-
-    return ($sid, $type, $vmid);
 }
 
 sub read_rules_config {
-- 
2.47.3