public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH ha-manager 11/16] lrm: rename update_lrm_status to flush_lrm_status
Date: Mon, 20 Jul 2026 14:37:00 +0200	[thread overview]
Message-ID: <20260720123705.216089-12-d.kral@proxmox.com> (raw)
In-Reply-To: <20260720123705.216089-1-d.kral@proxmox.com>

Make the method name similar to PVE::HA::Manager::flush_manager_status
as the term "flush" is more telling about the method writing something
out than the term "update" which could be an update in any direction.

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
 src/PVE/HA/LRM.pm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
index f459591f..bdf55d6e 100644
--- a/src/PVE/HA/LRM.pm
+++ b/src/PVE/HA/LRM.pm
@@ -156,7 +156,7 @@ sub shutdown_request {
 
     $self->{shutdown_request} = $haenv->get_time();
 
-    eval { $self->update_lrm_status() or die "not quorate?\n"; };
+    eval { $self->flush_lrm_status() or die "not quorate?\n"; };
     if (my $err = $@) {
         $haenv->log('err', "unable to update lrm status file - $err");
     }
@@ -187,7 +187,7 @@ sub set_local_status {
     $self->{status} = $new;
 }
 
-sub update_lrm_status {
+sub flush_lrm_status {
     my ($self) = @_;
 
     my $haenv = $self->{haenv};
@@ -366,7 +366,7 @@ sub work {
     my $haenv = $self->{haenv};
 
     if (!$wrote_lrm_status_at_startup) {
-        if ($self->update_lrm_status()) {
+        if ($self->flush_lrm_status()) {
             $wrote_lrm_status_at_startup = 1;
         } else {
             # do nothing
@@ -491,7 +491,7 @@ sub work {
 
         return 0 if $self->{shutdown_request};
 
-        $self->update_lrm_status();
+        $self->flush_lrm_status();
 
         $haenv->sleep(5);
 
@@ -559,7 +559,7 @@ sub work {
             $haenv->log('err', "got unexpected error - $err");
         }
 
-        $self->update_lrm_status();
+        $self->flush_lrm_status();
 
         return 0 if $shutdown;
 
@@ -629,7 +629,7 @@ sub work {
 
         $self->manage_resources() if !$exit_lrm;
 
-        $self->update_lrm_status();
+        $self->flush_lrm_status();
 
         return 0 if $exit_lrm;
 
-- 
2.47.3





  parent reply	other threads:[~2026-07-20 12:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20 12:36 [PATCH-SERIES ha-manager 00/16] some sid parsing and LRM speedup improvements Daniel Kral
2026-07-20 12:36 ` [PATCH ha-manager 01/16] make tidy Daniel Kral
2026-07-20 12:36 ` [PATCH ha-manager 02/16] resources: remove commented ipaddr resource type Daniel Kral
2026-07-20 12:36 ` [PATCH ha-manager 03/16] tree-wide: use the term vmid instead of name when referring to VMs/CTs Daniel Kral
2026-07-20 12:36 ` [PATCH ha-manager 04/16] api: resources: remove unused return values at parse_sid callsites Daniel Kral
2026-07-20 12:36 ` [PATCH ha-manager 05/16] make parse_sid always return an array Daniel Kral
2026-07-20 12:36 ` [PATCH ha-manager 06/16] config: use early returns in parse_sid Daniel Kral
2026-07-20 12:36 ` [PATCH ha-manager 07/16] config: make update_single_resource_config_inplace only allow sids Daniel Kral
2026-07-20 12:36 ` [PATCH ha-manager 08/16] introduce separate parse_vmid_or_sid helper subroutine Daniel Kral
2026-07-20 12:36 ` [PATCH ha-manager 09/16] drop the unmodified sid return array entry value from parse_sid Daniel Kral
2026-07-20 12:36 ` [PATCH ha-manager 10/16] lrm: document and initialize LRM instance properties Daniel Kral
2026-07-20 12:37 ` Daniel Kral [this message]
2026-07-20 12:37 ` [PATCH ha-manager 12/16] lrm: rename update_service_status to update_lrm_status Daniel Kral
2026-07-20 12:37 ` [PATCH ha-manager 13/16] lrm: update the service status once per work iteration Daniel Kral
2026-07-20 12:37 ` [PATCH ha-manager 14/16] lrm: read service config " Daniel Kral
2026-07-20 12:37 ` [PATCH ha-manager 15/16] lrm: compute valid service uids hash set " Daniel Kral
2026-07-20 12:37 ` [PATCH ha-manager 16/16] lrm: prune non-existent HA resources from results " Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260720123705.216089-12-d.kral@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal