[PATCH ha-manager 16/16] lrm: prune non-existent HA resources from results once per work iteration

[Daniel Kral <d.kral@proxmox.com>]

The $self->{service_status_uids} property is updated once per work
iteration. This makes the pruning and re-creation of the
$self->{results} hash on every resource command completion in
resource_command_finished() unnecessary.

In a test startup of 768 HA resources on a single node at the same time
showed a ~21.8 speedup for resource_command_finished().

+---------------------------+---------------+--------------+
|        Subroutine         | Before Change | After Change |
+---------------------------+---------------+--------------+
| check_active_workers      | 4.09ms        | 998µs        |
| resource_command_finished | 1.09ms        | 50µs         |
+---------------------------+---------------+--------------+

The profiling was done on a physical host with Devel::NYTProf 6.14 [0].

[0] https://metacpan.org/pod/Devel::NYTProf

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
 src/PVE/HA/LRM.pm | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
index 911672cb..41a925ff 100644
--- a/src/PVE/HA/LRM.pm
+++ b/src/PVE/HA/LRM.pm
@@ -199,6 +199,15 @@ sub flush_lrm_status {
 
     return 0 if !$haenv->quorate();
 
+    # remove results from non-existing HA resources just before writing it out
+    # to prevent persisting any leftover LRM results
+    my $results = {};
+    for my $id (keys $self->{results}->%*) {
+        next if !$self->{service_status_uids}->{$id};
+        $results->{$id} = $self->{results}->{$id};
+    }
+    $self->{results} = $results;
+
     my $lrm_status = {
         state => $self->{status}->{state},
         mode => $self->{mode},
@@ -890,13 +899,6 @@ sub resource_command_finished {
         state => $w->{state},
         exit_code => $exit_code,
     };
-
-    my $results = {};
-    foreach my $id (keys %{ $self->{results} }) {
-        next if !$self->{service_status_uids}->{$id};
-        $results->{$id} = $self->{results}->{$id};
-    }
-    $self->{results} = $results;
 }
 
 # processes the exit code from a finished resource agent, so that the CRM knows
-- 
2.47.3