[PATCH ha-manager 15/16] lrm: compute valid service uids hash set once per work iteration

[Daniel Kral <d.kral@proxmox.com>]

The $self->{service_status} property is read-only and updated once per
work iteration. This makes the recomputation on every resource command
completion in resource_command_finished() unnecessary.

In a test startup of 768 HA resources on a single node at the same time
showed a ~2.5 speedup for resource_command_finished().

+---------------------------+---------------+--------------+
|        Subroutine         | Before Change | After Change |
+---------------------------+---------------+--------------+
| check_active_workers      | 11.6ms        | 4.09ms       |
| resource_command_finished | 2.81ms        | 1.09ms       |
+---------------------------+---------------+--------------+

The profiling was done on a physical host with Devel::NYTProf 6.14 [0].

[0] https://metacpan.org/pod/Devel::NYTProf

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
 src/PVE/HA/LRM.pm | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)

diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
index 5f77580c..911672cb 100644
--- a/src/PVE/HA/LRM.pm
+++ b/src/PVE/HA/LRM.pm
@@ -47,6 +47,8 @@ sub new {
         # service_status from manager_status in current work() iteration
         # does contain all HA resources, users must filter for the assigned node
         service_status => {},
+        # UIDs from the service_status in current work() iteration
+        service_status_uids => {},
         # node_status from manager_status in current work() iteration
         # this is currently only used to check whether a fence for the node is requested
         # see $PVE::HA::NodeStatus::valid_node_states for possible values
@@ -220,7 +222,8 @@ C<L<manager_status|PVE::HA::Env::read_manager_status()>> and
 C<L<checked service_config|PVE::HA::Env::read_service_config()>>.
 
 The internal LRM status properties that are updated are C<node_status>,
-C<service_config>, C<service_status>, and C<shutdown_request>.
+C<service_config>, C<service_status>, C<service_status_uids>, and
+C<shutdown_request>.
 
 Returns 1 if the update was successful, otherwise returns undef.
 
@@ -237,7 +240,9 @@ sub update_lrm_status {
         return undef;
     } else {
         $self->{service_config} = $haenv->read_service_config();
-        $self->{service_status} = $ms->{service_status} || {};
+        my $ss = $ms->{service_status} || {};
+        $self->{service_status} = $ss;
+        $self->{service_status_uids} = { map { $ss->{$_}->{uid} => 1 } keys %$ss };
         my $nodename = $haenv->nodename();
         $self->{node_status} = $ms->{node_status}->{$nodename} || 'unknown';
 
@@ -886,19 +891,9 @@ sub resource_command_finished {
         exit_code => $exit_code,
     };
 
-    my $ss = $self->{service_status};
-
-    # compute hash of valid/existing uids
-    my $valid_uids = {};
-    foreach my $sid (keys %$ss) {
-        my $sd = $ss->{$sid};
-        next if !$sd->{uid};
-        $valid_uids->{ $sd->{uid} } = 1;
-    }
-
     my $results = {};
     foreach my $id (keys %{ $self->{results} }) {
-        next if !$valid_uids->{$id};
+        next if !$self->{service_status_uids}->{$id};
         $results->{$id} = $self->{results}->{$id};
     }
     $self->{results} = $results;
-- 
2.47.3