* [PATCH manager] ui: sdn: fabrics: node edit: fix typo to make editing node interfaces with existing IPv6 work
@ 2026-05-28 14:50 Fiona Ebner
2026-05-28 16:17 ` Lukas Sichert
2026-05-28 23:15 ` applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Fiona Ebner @ 2026-05-28 14:50 UTC (permalink / raw)
To: pve-devel
The data field is called 'ip6' in other places, not 'ipv6', for
example in the interfaces panel.
If there is an interface with a pre-assigned IPv6 address, it
previously would not show, but submitting an edit would fail with an
error that the additional property 'ipv6' is not defined in the
schema:
> interfaces[1]: invalid format - format error interfaces[1].ipv6:
> property is not defined in schema and the schema does not allow
> additional properties
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Hope I didn't miss any actual usages of 'ipv6'. A close look from
somebody who is not new to this part of the could would be
appreciated!
www/manager6/sdn/fabrics/NodeEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/sdn/fabrics/NodeEdit.js b/www/manager6/sdn/fabrics/NodeEdit.js
index ef4577cb..0ace12cd 100644
--- a/www/manager6/sdn/fabrics/NodeEdit.js
+++ b/www/manager6/sdn/fabrics/NodeEdit.js
@@ -155,7 +155,7 @@ Ext.define('PVE.sdn.Fabric.Node.Edit', {
name: iface.iface,
type: iface.type,
ip: iface.cidr,
- ipv6: iface.cidr6,
+ ip6: iface.cidr6,
}));
if (me.includeWireguardInterfaces) {
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH manager] ui: sdn: fabrics: node edit: fix typo to make editing node interfaces with existing IPv6 work
2026-05-28 14:50 [PATCH manager] ui: sdn: fabrics: node edit: fix typo to make editing node interfaces with existing IPv6 work Fiona Ebner
@ 2026-05-28 16:17 ` Lukas Sichert
2026-05-28 23:15 ` applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Lukas Sichert @ 2026-05-28 16:17 UTC (permalink / raw)
To: Fiona Ebner, pve-devel
Thanks for sending the patch.
I ran into the same issue today, where I could not select the bridge
when adding nodes with IPv6 addresses to an OpenFabric fabric, while
using the CLI this was possible.
After applying the patch, the issue was resolved.
About the change: OpenFabric is currently the only fabric supporting
IPv6, and its schema defines the property as 'ip6', so the change looks
correct to me.[1]
Tested-by: Lukas Sichert <l.sichert@proxmox.com>
Reviewed-by: Lukas Sichert <l.sichert@proxmox.com>
[1] pve.proxmox.com/pve-docs/chapter-pvesdn.html#_configuration
On 2026-05-28 16:50, Fiona Ebner <f.ebner@proxmox.com> wrote:
> The data field is called 'ip6' in other places, not 'ipv6', for
> example in the interfaces panel.
>
> If there is an interface with a pre-assigned IPv6 address, it
> previously would not show, but submitting an edit would fail with an
> error that the additional property 'ipv6' is not defined in the
> schema:
>
>> interfaces[1]: invalid format - format error interfaces[1].ipv6:
>> property is not defined in schema and the schema does not allow
>> additional properties
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Hope I didn't miss any actual usages of 'ipv6'. A close look from
> somebody who is not new to this part of the could would be
> appreciated!
>
> www/manager6/sdn/fabrics/NodeEdit.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/sdn/fabrics/NodeEdit.js b/www/manager6/sdn/fabrics/NodeEdit.js
> index ef4577cb..0ace12cd 100644
> --- a/www/manager6/sdn/fabrics/NodeEdit.js
> +++ b/www/manager6/sdn/fabrics/NodeEdit.js
> @@ -155,7 +155,7 @@ Ext.define('PVE.sdn.Fabric.Node.Edit', {
> name: iface.iface,
> type: iface.type,
> ip: iface.cidr,
> - ipv6: iface.cidr6,
> + ip6: iface.cidr6,
> }));
>
> if (me.includeWireguardInterfaces) {
> --
> 2.47.3
^ permalink raw reply [flat|nested] 3+ messages in thread* applied: [PATCH manager] ui: sdn: fabrics: node edit: fix typo to make editing node interfaces with existing IPv6 work
2026-05-28 14:50 [PATCH manager] ui: sdn: fabrics: node edit: fix typo to make editing node interfaces with existing IPv6 work Fiona Ebner
2026-05-28 16:17 ` Lukas Sichert
@ 2026-05-28 23:15 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2026-05-28 23:15 UTC (permalink / raw)
To: pve-devel, Fiona Ebner
On Thu, 28 May 2026 16:50:43 +0200, Fiona Ebner wrote:
> The data field is called 'ip6' in other places, not 'ipv6', for
> example in the interfaces panel.
>
> If there is an interface with a pre-assigned IPv6 address, it
> previously would not show, but submitting an edit would fail with an
> error that the additional property 'ipv6' is not defined in the
> schema:
>
> [...]
Applied, thanks!
[1/1] ui: sdn: fabrics: node edit: fix typo to make editing node interfaces with existing IPv6 work
commit: 94e354e4521b575d7f7fcd01d3befa8b2224c663
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-28 23:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-28 14:50 [PATCH manager] ui: sdn: fabrics: node edit: fix typo to make editing node interfaces with existing IPv6 work Fiona Ebner
2026-05-28 16:17 ` Lukas Sichert
2026-05-28 23:15 ` applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox