public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Sichert" <l.sichert@proxmox.com>
To: "Fiona Ebner" <f.ebner@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH manager] ui: sdn: fabrics: node edit: fix typo to make editing node interfaces with existing IPv6 work
Date: Thu, 28 May 2026 18:17:47 +0200	[thread overview]
Message-ID: <DIUG1NEX9GQ5.3JX540WGLLA8E@proxmox.com> (raw)
In-Reply-To: <20260528145222.639478-1-f.ebner@proxmox.com>

Thanks for sending the patch.
I ran into the same issue today, where I could not select the bridge
when adding nodes with IPv6 addresses to an OpenFabric fabric, while
using the CLI this was possible.
After applying the patch, the issue was resolved.

About the change: OpenFabric is currently the only fabric supporting
IPv6, and its schema defines the property as 'ip6', so the change looks
correct to me.[1]

Tested-by: Lukas Sichert <l.sichert@proxmox.com>
Reviewed-by: Lukas Sichert <l.sichert@proxmox.com>

[1] pve.proxmox.com/pve-docs/chapter-pvesdn.html#_configuration

On 2026-05-28 16:50, Fiona Ebner <f.ebner@proxmox.com> wrote:

> The data field is called 'ip6' in other places, not 'ipv6', for
> example in the interfaces panel.
>
> If there is an interface with a pre-assigned IPv6 address, it
> previously would not show, but submitting an edit would fail with an
> error that the additional property 'ipv6' is not defined in the
> schema:
>
>> interfaces[1]: invalid format - format error interfaces[1].ipv6:
>> property is not defined in schema and the schema does not allow
>> additional properties
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Hope I didn't miss any actual usages of 'ipv6'. A close look from
> somebody who is not new to this part of the could would be
> appreciated!
>
>  www/manager6/sdn/fabrics/NodeEdit.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/sdn/fabrics/NodeEdit.js b/www/manager6/sdn/fabrics/NodeEdit.js
> index ef4577cb..0ace12cd 100644
> --- a/www/manager6/sdn/fabrics/NodeEdit.js
> +++ b/www/manager6/sdn/fabrics/NodeEdit.js
> @@ -155,7 +155,7 @@ Ext.define('PVE.sdn.Fabric.Node.Edit', {
>              name: iface.iface,
>              type: iface.type,
>              ip: iface.cidr,
> -            ipv6: iface.cidr6,
> +            ip6: iface.cidr6,
>          }));
>  
>          if (me.includeWireguardInterfaces) {
> -- 
> 2.47.3





  reply	other threads:[~2026-05-28 16:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-28 14:50 [PATCH manager] ui: sdn: fabrics: node edit: fix typo to make editing node interfaces with existing IPv6 work Fiona Ebner
2026-05-28 16:17 ` Lukas Sichert [this message]
2026-05-28 23:15 ` applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DIUG1NEX9GQ5.3JX540WGLLA8E@proxmox.com \
    --to=l.sichert@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal