[PATCH manager 0/2] ui & ux polishing for pve manager

[PATCH manager 0/2] ui & ux polishing for pve manager

[Shannon Sterz]

this includes a couple of minor tweaks for the pve-manager such as:

* adding online help properties for route maps and prefix lists
* aligning the "Property" and "Value" column's cells in the "Add/Edit:
  Route Map Entry" dialog

Shannon Sterz (2):
  ui: route map & prefix list panel: add online help property
  ui: route map panel: fix alignment of value cells when adding/editing

 www/manager6/sdn/PrefixListPanel.js | 1 +
 www/manager6/sdn/RouteMapPanel.js   | 3 +++
 2 files changed, 4 insertions(+)

--
2.47.3

[PATCH manager 1/2] ui: route map & prefix list panel: add online help property

[Shannon Sterz]

so the appropriate chapter of the docs is linked in the top right
"Help" button.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 www/manager6/sdn/PrefixListPanel.js | 1 +
 www/manager6/sdn/RouteMapPanel.js   | 1 +
 2 files changed, 2 insertions(+)

diff --git a/www/manager6/sdn/PrefixListPanel.js b/www/manager6/sdn/PrefixListPanel.js
index d8ce3db8c..200b6b7e7 100644
--- a/www/manager6/sdn/PrefixListPanel.js
+++ b/www/manager6/sdn/PrefixListPanel.js
@@ -295,6 +295,7 @@ Ext.define('PVE.sdn.PrefixListPanel', {
     // keep "prefix list" as-is:
     // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
     emptyText: gettext('No prefix list configured'),
+    onlineHelp: 'pvesdn_config_prefix_lists',
 
     viewModel: {
         formulas: {
diff --git a/www/manager6/sdn/RouteMapPanel.js b/www/manager6/sdn/RouteMapPanel.js
index 46f243fb9..d044a854f 100644
--- a/www/manager6/sdn/RouteMapPanel.js
+++ b/www/manager6/sdn/RouteMapPanel.js
@@ -828,6 +828,7 @@ Ext.define('PVE.sdn.RouteMapPanel', {
     // prefer to keep it as-is:
     // https://docs.frrouting.org/en/latest/routemap.html
     emptyText: gettext('No route maps configured.'),
+    onlineHelp: 'pvesdn_config_route_maps',
 
     store: {
         autoLoad: true,
-- 
2.47.3

[PATCH manager 2/2] ui: route map panel: fix alignment of value cells when adding/editing

[Shannon Sterz]

usually when a textfield-like component is rendered in a table, extjs
will add the `x-textfield-default-cell` class to the table's cell.
this renders textfield-like components without padding. since the
"Property" column uses standard `proxmoxKVComboBox` components, that
works correctly for that column.

however, the "Value" columns use a wrapper component that needs to be
a container. this is necessary, so they can dynamically render their
child depending on which value is set in the "Property" column.
however, this leads to ExtJS never setting the
`x-textfield-default-cell` class, meaning that the padding is never
stripped. leading to the "Property" and "Value" column's cell cells
being misaligned.

this patch fixes that by manually setting that class for the cells.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 www/manager6/sdn/RouteMapPanel.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/manager6/sdn/RouteMapPanel.js b/www/manager6/sdn/RouteMapPanel.js
index d044a854f..76f56a183 100644
--- a/www/manager6/sdn/RouteMapPanel.js
+++ b/www/manager6/sdn/RouteMapPanel.js
@@ -230,6 +230,7 @@ Ext.define('PVE.sdn.RouteMapSetField', {
             header: gettext('Value'),
             flex: 1,
             xtype: 'widgetcolumn',
+            tdCls: 'x-textfield-default-cell',
             widget: {
                 xtype: 'pveSdnRouteMapSetValueField',
                 bind: {
@@ -489,6 +490,7 @@ Ext.define('PVE.sdn.RouteMapMatchField', {
             header: gettext('Value'),
             flex: 1,
             xtype: 'widgetcolumn',
+            tdCls: 'x-textfield-default-cell',
             widget: {
                 xtype: 'pveSdnRouteMapMatchValueField',
                 bind: {
-- 
2.47.3