public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shannon Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 2/2] ui: route map panel: fix alignment of value cells when adding/editing
Date: Tue, 19 May 2026 17:04:15 +0200	[thread overview]
Message-ID: <20260519150415.334856-3-s.sterz@proxmox.com> (raw)
In-Reply-To: <20260519150415.334856-1-s.sterz@proxmox.com>

usually when a textfield-like component is rendered in a table, extjs
will add the `x-textfield-default-cell` class to the table's cell.
this renders textfield-like components without padding. since the
"Property" column uses standard `proxmoxKVComboBox` components, that
works correctly for that column.

however, the "Value" columns use a wrapper component that needs to be
a container. this is necessary, so they can dynamically render their
child depending on which value is set in the "Property" column.
however, this leads to ExtJS never setting the
`x-textfield-default-cell` class, meaning that the padding is never
stripped. leading to the "Property" and "Value" column's cell cells
being misaligned.

this patch fixes that by manually setting that class for the cells.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 www/manager6/sdn/RouteMapPanel.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/manager6/sdn/RouteMapPanel.js b/www/manager6/sdn/RouteMapPanel.js
index d044a854f..76f56a183 100644
--- a/www/manager6/sdn/RouteMapPanel.js
+++ b/www/manager6/sdn/RouteMapPanel.js
@@ -230,6 +230,7 @@ Ext.define('PVE.sdn.RouteMapSetField', {
             header: gettext('Value'),
             flex: 1,
             xtype: 'widgetcolumn',
+            tdCls: 'x-textfield-default-cell',
             widget: {
                 xtype: 'pveSdnRouteMapSetValueField',
                 bind: {
@@ -489,6 +490,7 @@ Ext.define('PVE.sdn.RouteMapMatchField', {
             header: gettext('Value'),
             flex: 1,
             xtype: 'widgetcolumn',
+            tdCls: 'x-textfield-default-cell',
             widget: {
                 xtype: 'pveSdnRouteMapMatchValueField',
                 bind: {
-- 
2.47.3





      parent reply	other threads:[~2026-05-19 15:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 15:04 [PATCH manager 0/2] ui & ux polishing for pve manager Shannon Sterz
2026-05-19 15:04 ` [PATCH manager 1/2] ui: route map & prefix list panel: add online help property Shannon Sterz
2026-05-19 15:04 ` Shannon Sterz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519150415.334856-3-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal