From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EC8551FF141 for ; Tue, 19 May 2026 17:04:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7F097BD51; Tue, 19 May 2026 17:04:22 +0200 (CEST) From: Shannon Sterz To: pve-devel@lists.proxmox.com Subject: [PATCH manager 2/2] ui: route map panel: fix alignment of value cells when adding/editing Date: Tue, 19 May 2026 17:04:15 +0200 Message-ID: <20260519150415.334856-3-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260519150415.334856-1-s.sterz@proxmox.com> References: <20260519150415.334856-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779203043983 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.113 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GYIJQ4G4GTHS5RGWBVVDUXWIQCQWX6OR X-Message-ID-Hash: GYIJQ4G4GTHS5RGWBVVDUXWIQCQWX6OR X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: usually when a textfield-like component is rendered in a table, extjs will add the `x-textfield-default-cell` class to the table's cell. this renders textfield-like components without padding. since the "Property" column uses standard `proxmoxKVComboBox` components, that works correctly for that column. however, the "Value" columns use a wrapper component that needs to be a container. this is necessary, so they can dynamically render their child depending on which value is set in the "Property" column. however, this leads to ExtJS never setting the `x-textfield-default-cell` class, meaning that the padding is never stripped. leading to the "Property" and "Value" column's cell cells being misaligned. this patch fixes that by manually setting that class for the cells. Signed-off-by: Shannon Sterz --- www/manager6/sdn/RouteMapPanel.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/sdn/RouteMapPanel.js b/www/manager6/sdn/RouteMapPanel.js index d044a854f..76f56a183 100644 --- a/www/manager6/sdn/RouteMapPanel.js +++ b/www/manager6/sdn/RouteMapPanel.js @@ -230,6 +230,7 @@ Ext.define('PVE.sdn.RouteMapSetField', { header: gettext('Value'), flex: 1, xtype: 'widgetcolumn', + tdCls: 'x-textfield-default-cell', widget: { xtype: 'pveSdnRouteMapSetValueField', bind: { @@ -489,6 +490,7 @@ Ext.define('PVE.sdn.RouteMapMatchField', { header: gettext('Value'), flex: 1, xtype: 'widgetcolumn', + tdCls: 'x-textfield-default-cell', widget: { xtype: 'pveSdnRouteMapMatchValueField', bind: { -- 2.47.3