public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH proxmox-widget-toolkit 0/4] ui: network: add columns for more interface settings
@ 2026-11-20 16:32 Stefan Hanreich
  2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 1/4] node: network: add bond-primary column Stefan Hanreich
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Stefan Hanreich @ 2026-11-20 16:32 UTC (permalink / raw)
  To: pve-devel

Some interface settings could only be checked by opening the edit window
of each interface. Add columns for the bond-primary, VRF, IPv4
forwarding and bridge VLAN IDs settings to the network overview, so
they can be compared across all interfaces at a glance.

All new columns are hidden by default.


proxmox-widget-toolkit:

Stefan Hanreich (4):
  node: network: add bond-primary column
  node: network: add VRF column
  node: network: add IPv4 forwarding column
  node: network: add bridge VLAN IDs column

 src/node/NetworkView.js | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)


Summary over all repositories:
  1 files changed, 26 insertions(+), 0 deletions(-)

-- 
Generated by murpp 0.12.1




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH proxmox-widget-toolkit 1/4] node: network: add bond-primary column
  2026-11-20 16:32 [PATCH proxmox-widget-toolkit 0/4] ui: network: add columns for more interface settings Stefan Hanreich
@ 2026-11-20 16:32 ` Stefan Hanreich
  2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 2/4] node: network: add VRF column Stefan Hanreich
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Stefan Hanreich @ 2026-11-20 16:32 UTC (permalink / raw)
  To: pve-devel

The primary interface of an active-backup bond could only be seen by
opening its edit window. Add a column for it, hidden by default like
the hash policy column, as it only applies to some bond modes.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 src/node/NetworkView.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/node/NetworkView.js b/src/node/NetworkView.js
index f58cd93..0f40a33 100644
--- a/src/node/NetworkView.js
+++ b/src/node/NetworkView.js
@@ -362,6 +362,11 @@ Ext.define('Proxmox.node.NetworkView', {
                             hidden: true,
                             dataIndex: 'bond_xmit_hash_policy',
                         },
+                        {
+                            header: gettext('Primary Slave'),
+                            hidden: true,
+                            dataIndex: 'bond-primary',
+                        },
                         {
                             header: gettext('IP address'),
                             sortable: true,
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH proxmox-widget-toolkit 2/4] node: network: add VRF column
  2026-11-20 16:32 [PATCH proxmox-widget-toolkit 0/4] ui: network: add columns for more interface settings Stefan Hanreich
  2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 1/4] node: network: add bond-primary column Stefan Hanreich
@ 2026-11-20 16:32 ` Stefan Hanreich
  2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 3/4] node: network: add IPv4 forwarding column Stefan Hanreich
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Stefan Hanreich @ 2026-11-20 16:32 UTC (permalink / raw)
  To: pve-devel

The VRF an interface is a member of could only be seen in the edit
window.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 src/node/NetworkView.js | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/node/NetworkView.js b/src/node/NetworkView.js
index 0f40a33..10c0af1 100644
--- a/src/node/NetworkView.js
+++ b/src/node/NetworkView.js
@@ -397,6 +397,12 @@ Ext.define('Proxmox.node.NetworkView', {
                             dataIndex: 'gateway',
                             renderer: renderer_generator('gateway'),
                         },
+                        {
+                            header: gettext('VRF'),
+                            hidden: true,
+                            sortable: true,
+                            dataIndex: 'vrf',
+                        },
                         {
                             header: gettext('VLAN ID'),
                             hidden: true,
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH proxmox-widget-toolkit 3/4] node: network: add IPv4 forwarding column
  2026-11-20 16:32 [PATCH proxmox-widget-toolkit 0/4] ui: network: add columns for more interface settings Stefan Hanreich
  2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 1/4] node: network: add bond-primary column Stefan Hanreich
  2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 2/4] node: network: add VRF column Stefan Hanreich
@ 2026-11-20 16:32 ` Stefan Hanreich
  2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 4/4] node: network: add bridge VLAN IDs column Stefan Hanreich
  2026-11-21 20:59 ` [PATCH proxmox-widget-toolkit 0/4] ui: network: add columns for more interface settings Thomas Lamprecht
  4 siblings, 0 replies; 6+ messages in thread
From: Stefan Hanreich @ 2026-11-20 16:32 UTC (permalink / raw)
  To: pve-devel

Show the per-interface IPv4 forwarding setting, which is needed for
interfaces receiving routed traffic, like the uplinks of an SDN zone
with a dedicated VRF.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 src/node/NetworkView.js | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/node/NetworkView.js b/src/node/NetworkView.js
index 10c0af1..e1d1f8d 100644
--- a/src/node/NetworkView.js
+++ b/src/node/NetworkView.js
@@ -403,6 +403,16 @@ Ext.define('Proxmox.node.NetworkView', {
                             sortable: true,
                             dataIndex: 'vrf',
                         },
+                        {
+                            xtype: 'booleancolumn',
+                            header: gettext('IPv4 Forwarding'),
+                            hidden: true,
+                            sortable: true,
+                            dataIndex: 'ip-forward',
+                            trueText: Proxmox.Utils.enabledText,
+                            falseText: Proxmox.Utils.disabledText,
+                            undefinedText: Proxmox.Utils.defaultText,
+                        },
                         {
                             header: gettext('VLAN ID'),
                             hidden: true,
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH proxmox-widget-toolkit 4/4] node: network: add bridge VLAN IDs column
  2026-11-20 16:32 [PATCH proxmox-widget-toolkit 0/4] ui: network: add columns for more interface settings Stefan Hanreich
                   ` (2 preceding siblings ...)
  2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 3/4] node: network: add IPv4 forwarding column Stefan Hanreich
@ 2026-11-20 16:32 ` Stefan Hanreich
  2026-11-21 20:59 ` [PATCH proxmox-widget-toolkit 0/4] ui: network: add columns for more interface settings Thomas Lamprecht
  4 siblings, 0 replies; 6+ messages in thread
From: Stefan Hanreich @ 2026-11-20 16:32 UTC (permalink / raw)
  To: pve-devel

The VLAN IDs of a VLAN-aware bridge could only be seen in the edit
window.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 src/node/NetworkView.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/node/NetworkView.js b/src/node/NetworkView.js
index e1d1f8d..bd9a242 100644
--- a/src/node/NetworkView.js
+++ b/src/node/NetworkView.js
@@ -336,6 +336,11 @@ Ext.define('Proxmox.node.NetworkView', {
                             falseText: Proxmox.Utils.noText,
                             undefinedText: Proxmox.Utils.noText,
                         },
+                        {
+                            header: gettext('VLAN IDs'),
+                            hidden: true,
+                            dataIndex: 'bridge_vids',
+                        },
                         {
                             header: gettext('Ports/Slaves'),
                             dataIndex: 'type',
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH proxmox-widget-toolkit 0/4] ui: network: add columns for more interface settings
  2026-11-20 16:32 [PATCH proxmox-widget-toolkit 0/4] ui: network: add columns for more interface settings Stefan Hanreich
                   ` (3 preceding siblings ...)
  2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 4/4] node: network: add bridge VLAN IDs column Stefan Hanreich
@ 2026-11-21 20:59 ` Thomas Lamprecht
  4 siblings, 0 replies; 6+ messages in thread
From: Thomas Lamprecht @ 2026-11-21 20:59 UTC (permalink / raw)
  To: pve-devel, Stefan Hanreich

On Fri, 20 Nov 2026 17:32:13 +0100, Stefan Hanreich wrote:
> Some interface settings could only be checked by opening the edit window
> of each interface. Add columns for the bond-primary, VRF, IPv4
> forwarding and bridge VLAN IDs settings to the network overview, so
> they can be compared across all interfaces at a glance.
> 
> [...]

Applied, thanks!

Tested that a layout saved with the old version still applies to the
same columns.

What I changed in your patches:
- Add the new columns at the end, with a stateId. ExtJS identifies
  columns without one by position, so inserting them in the middle made
  saved layouts show or hide the wrong columns.
- Only offer VRF, IPv4 Forwarding and Bridge VLAN IDs if the product can
  edit them, so PBS does not get columns that stay empty.
- Rename 'VLAN IDs' to 'Bridge VLAN IDs' to tell it apart from
  'VLAN ID'.

[1/4] node: network: add bond-primary column
      commit: 9a49a38eb2640e2fcd820cd152bffe8655be8276
[2/4] node: network: add VRF column
      commit: 38b4b615032512196f1b5d7e07c78457d85653b0
[3/4] node: network: add IPv4 forwarding column
      commit: f625f5b3b1b89cda902cef8d3f035e2beaf6e10d
[4/4] node: network: add bridge VLAN IDs column
      commit: c50a6e024f8065c011f6e1db66df2f5081c3149e




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-21 21:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 16:32 [PATCH proxmox-widget-toolkit 0/4] ui: network: add columns for more interface settings Stefan Hanreich
2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 1/4] node: network: add bond-primary column Stefan Hanreich
2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 2/4] node: network: add VRF column Stefan Hanreich
2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 3/4] node: network: add IPv4 forwarding column Stefan Hanreich
2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 4/4] node: network: add bridge VLAN IDs column Stefan Hanreich
2026-11-21 20:59 ` [PATCH proxmox-widget-toolkit 0/4] ui: network: add columns for more interface settings Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal