From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 41D501FF0E4 for ; Sat, 21 Nov 2026 22:00:05 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 2D72E21760; Sat, 21 Nov 2026 21:59:23 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Stefan Hanreich Subject: Re: [PATCH proxmox-widget-toolkit 0/4] ui: network: add columns for more interface settings Date: Sat, 21 Nov 2026 21:59:04 +0100 Message-ID: <179528709033419.3238989.4592131357841216329.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120163218.560776-1-s.hanreich@proxmox.com> References: <20261120163218.560776-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795294756536 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.147 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WPNAEASE5B6IIUBC4ML4XWLPBAHYT2VQ X-Message-ID-Hash: WPNAEASE5B6IIUBC4ML4XWLPBAHYT2VQ X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 20 Nov 2026 17:32:13 +0100, Stefan Hanreich wrote: > Some interface settings could only be checked by opening the edit window > of each interface. Add columns for the bond-primary, VRF, IPv4 > forwarding and bridge VLAN IDs settings to the network overview, so > they can be compared across all interfaces at a glance. > > [...] Applied, thanks! Tested that a layout saved with the old version still applies to the same columns. What I changed in your patches: - Add the new columns at the end, with a stateId. ExtJS identifies columns without one by position, so inserting them in the middle made saved layouts show or hide the wrong columns. - Only offer VRF, IPv4 Forwarding and Bridge VLAN IDs if the product can edit them, so PBS does not get columns that stay empty. - Rename 'VLAN IDs' to 'Bridge VLAN IDs' to tell it apart from 'VLAN ID'. [1/4] node: network: add bond-primary column commit: 9a49a38eb2640e2fcd820cd152bffe8655be8276 [2/4] node: network: add VRF column commit: 38b4b615032512196f1b5d7e07c78457d85653b0 [3/4] node: network: add IPv4 forwarding column commit: f625f5b3b1b89cda902cef8d3f035e2beaf6e10d [4/4] node: network: add bridge VLAN IDs column commit: c50a6e024f8065c011f6e1db66df2f5081c3149e