public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [PATCH proxmox-widget-toolkit 0/4] ui: network: add columns for more interface settings
Date: Sat, 21 Nov 2026 21:59:04 +0100	[thread overview]
Message-ID: <179528709033419.3238989.4592131357841216329.b4-ty@b4> (raw)
In-Reply-To: <20261120163218.560776-1-s.hanreich@proxmox.com>

On Fri, 20 Nov 2026 17:32:13 +0100, Stefan Hanreich wrote:
> Some interface settings could only be checked by opening the edit window
> of each interface. Add columns for the bond-primary, VRF, IPv4
> forwarding and bridge VLAN IDs settings to the network overview, so
> they can be compared across all interfaces at a glance.
> 
> [...]

Applied, thanks!

Tested that a layout saved with the old version still applies to the
same columns.

What I changed in your patches:
- Add the new columns at the end, with a stateId. ExtJS identifies
  columns without one by position, so inserting them in the middle made
  saved layouts show or hide the wrong columns.
- Only offer VRF, IPv4 Forwarding and Bridge VLAN IDs if the product can
  edit them, so PBS does not get columns that stay empty.
- Rename 'VLAN IDs' to 'Bridge VLAN IDs' to tell it apart from
  'VLAN ID'.

[1/4] node: network: add bond-primary column
      commit: 9a49a38eb2640e2fcd820cd152bffe8655be8276
[2/4] node: network: add VRF column
      commit: 38b4b615032512196f1b5d7e07c78457d85653b0
[3/4] node: network: add IPv4 forwarding column
      commit: f625f5b3b1b89cda902cef8d3f035e2beaf6e10d
[4/4] node: network: add bridge VLAN IDs column
      commit: c50a6e024f8065c011f6e1db66df2f5081c3149e




      parent reply	other threads:[~2026-11-21 21:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 16:32 [PATCH proxmox-widget-toolkit 0/4] ui: network: add columns for more interface settings Stefan Hanreich
2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 1/4] node: network: add bond-primary column Stefan Hanreich
2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 2/4] node: network: add VRF column Stefan Hanreich
2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 3/4] node: network: add IPv4 forwarding column Stefan Hanreich
2026-11-20 16:32 ` [PATCH proxmox-widget-toolkit 4/4] node: network: add bridge VLAN IDs column Stefan Hanreich
2026-11-21 20:59 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179528709033419.3238989.4592131357841216329.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal