[PATCH proxmox-widget-toolkit] utils: fix multi line error message rendering for store error mask

[PATCH proxmox-widget-toolkit] utils: fix multi line error message rendering for store error mask

[Christian Ebner]

Since commit 86b2264d ("utils: mon store errors: htmlEncode error
message") the full message passed to the error mask is html encoded.

This however leads to incorrect rendering of multiline errors, since
gathered via Proxmox.Utils.getResponseErrorMessage() separates lines
via `<br>` tag and already html encodes them. One crucial exception
is however the error status text, not covered by html encoding in
Proxmox.Utils.getResponseErrorMessage().

Since the current implementation breaks multi-line error rendering
for several places in the PBS UI, fix the rendering by not encoding
the full return value of Proxmox.Utils.getResponseErrorMessage(),
but rather limit to the content of the error itself.

Fixes:86b2264d ("utils: mon store errors: htmlEncode error message")
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/Utils.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Utils.js b/src/Utils.js
index cd24787..73189fd 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -414,7 +414,7 @@ Ext.define('Proxmox.Utils', {
             if (!err.statusText) {
                 return gettext('Connection error');
             }
-            let msg = [`${err.statusText} (${err.status})`];
+            let msg = [Ext.String.htmlEncode(`${err.statusText} (${err.status})`)];
             if (err.response && err.response.responseText) {
                 let txt = err.response.responseText;
                 try {
@@ -468,7 +468,7 @@ Ext.define('Proxmox.Utils', {
                 let error = request._operation.getError();
                 let msg = Proxmox.Utils.getResponseErrorMessage(error);
                 if (!errorCallback || !errorCallback(error, msg)) {
-                    Proxmox.Utils.setErrorMask(component, Ext.htmlEncode(msg));
+                    Proxmox.Utils.setErrorMask(component, msg);
                 }
             });
         },
-- 
2.47.3

applied: [PATCH proxmox-widget-toolkit] utils: fix multi line error message rendering for store error mask

[Thomas Lamprecht]

On Thu, 15 Oct 2026 17:11:10 +0200, Christian Ebner wrote:
> Since commit 86b2264d ("utils: mon store errors: htmlEncode error
> message") the full message passed to the error mask is html encoded.
> 
> This however leads to incorrect rendering of multiline errors, since
> gathered via Proxmox.Utils.getResponseErrorMessage() separates lines
> via `<br>` tag and already html encodes them. One crucial exception
> is however the error status text, not covered by html encoding in
> Proxmox.Utils.getResponseErrorMessage().
> 
> [...]

Applied, thanks!

[1/1] utils: fix multi line error message rendering for store error mask
      commit: d353f9466dee3e6c35a8af26e83899a6a580169c