public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Christian Ebner <c.ebner@proxmox.com>
Subject: applied: [PATCH proxmox-widget-toolkit] utils: fix multi line error message rendering for store error mask
Date: Thu, 29 Oct 2026 20:27:25 +0100	[thread overview]
Message-ID: <179330204049.2026601.3559144239336502021.b4-ty@b4> (raw)
In-Reply-To: <20261015151110.425812-1-c.ebner@proxmox.com>

On Thu, 15 Oct 2026 17:11:10 +0200, Christian Ebner wrote:
> Since commit 86b2264d ("utils: mon store errors: htmlEncode error
> message") the full message passed to the error mask is html encoded.
> 
> This however leads to incorrect rendering of multiline errors, since
> gathered via Proxmox.Utils.getResponseErrorMessage() separates lines
> via `<br>` tag and already html encodes them. One crucial exception
> is however the error status text, not covered by html encoding in
> Proxmox.Utils.getResponseErrorMessage().
> 
> [...]

Applied, thanks!

[1/1] utils: fix multi line error message rendering for store error mask
      commit: d353f9466dee3e6c35a8af26e83899a6a580169c




      reply	other threads:[~2026-10-29 19:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 15:11 [PATCH proxmox-widget-toolkit] utils: fix multi line error message rendering for store error mask Christian Ebner
2026-10-29 19:27 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179330204049.2026601.3559144239336502021.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal