From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 5B2B01FF0BC for ; Thu, 29 Oct 2026 20:27:40 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 019F32141D; Thu, 29 Oct 2026 20:27:37 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Christian Ebner Subject: applied: [PATCH proxmox-widget-toolkit] utils: fix multi line error message rendering for store error mask Date: Thu, 29 Oct 2026 20:27:25 +0100 Message-ID: <179330204049.2026601.3559144239336502021.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261015151110.425812-1-c.ebner@proxmox.com> References: <20261015151110.425812-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793302052406 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.433 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VSJL6B5REWPCVNFXK6KQBJMHY5QJ7KPI X-Message-ID-Hash: VSJL6B5REWPCVNFXK6KQBJMHY5QJ7KPI X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 15 Oct 2026 17:11:10 +0200, Christian Ebner wrote: > Since commit 86b2264d ("utils: mon store errors: htmlEncode error > message") the full message passed to the error mask is html encoded. > > This however leads to incorrect rendering of multiline errors, since > gathered via Proxmox.Utils.getResponseErrorMessage() separates lines > via `
` tag and already html encodes them. One crucial exception > is however the error status text, not covered by html encoding in > Proxmox.Utils.getResponseErrorMessage(). > > [...] Applied, thanks! [1/1] utils: fix multi line error message rendering for store error mask commit: d353f9466dee3e6c35a8af26e83899a6a580169c