* [PATCH widget-toolkit] location edit: disallow ',' and '=' for the name
@ 2026-05-19 13:37 Dominik Csapak
2026-05-19 18:32 ` applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2026-05-19 13:37 UTC (permalink / raw)
To: pve-devel
otherwise one could 'inject' a latitude and longitude into the
value there. The backend still properly checks the property string
anyway.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/window/LocationEdit.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/window/LocationEdit.js b/src/window/LocationEdit.js
index f7b6c6d..4042086 100644
--- a/src/window/LocationEdit.js
+++ b/src/window/LocationEdit.js
@@ -33,6 +33,8 @@ Ext.define('Proxmox.window.LocationEdit', {
fieldLabel: gettext('Name'),
allowBlank: true,
emptyText: gettext('Optional'),
+ regex: /^[^,=]+$/,
+ regexText: gettext('No "," and "=" allowed'),
name: 'name',
},
{
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* applied: [PATCH widget-toolkit] location edit: disallow ',' and '=' for the name
2026-05-19 13:37 [PATCH widget-toolkit] location edit: disallow ',' and '=' for the name Dominik Csapak
@ 2026-05-19 18:32 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-05-19 18:32 UTC (permalink / raw)
To: pve-devel, Dominik Csapak
On Tue, 19 May 2026 15:37:23 +0200, Dominik Csapak wrote:
> otherwise one could 'inject' a latitude and longitude into the
> value there. The backend still properly checks the property string
> anyway.
Applied, thanks!
[1/1] location edit: disallow ',' and '=' for the name
commit: 345cb86eb8fbb1ce187395059f840d15e1aa7420
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-19 18:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-19 13:37 [PATCH widget-toolkit] location edit: disallow ',' and '=' for the name Dominik Csapak
2026-05-19 18:32 ` applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox