From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8A37F1FF141 for ; Tue, 19 May 2026 15:38:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1A9C7B7B; Tue, 19 May 2026 15:38:05 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH widget-toolkit] location edit: disallow ',' and '=' for the name Date: Tue, 19 May 2026 15:37:23 +0200 Message-ID: <20260519133727.3064789-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ISR4FJQEPG55YJBD4MDP32KBXF52ODKJ X-Message-ID-Hash: ISR4FJQEPG55YJBD4MDP32KBXF52ODKJ X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: otherwise one could 'inject' a latitude and longitude into the value there. The backend still properly checks the property string anyway. Signed-off-by: Dominik Csapak --- src/window/LocationEdit.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/window/LocationEdit.js b/src/window/LocationEdit.js index f7b6c6d..4042086 100644 --- a/src/window/LocationEdit.js +++ b/src/window/LocationEdit.js @@ -33,6 +33,8 @@ Ext.define('Proxmox.window.LocationEdit', { fieldLabel: gettext('Name'), allowBlank: true, emptyText: gettext('Optional'), + regex: /^[^,=]+$/, + regexText: gettext('No "," and "=" allowed'), name: 'name', }, { -- 2.47.3