public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH widget-toolkit] location edit: disallow ',' and '=' for the name
Date: Tue, 19 May 2026 15:37:23 +0200	[thread overview]
Message-ID: <20260519133727.3064789-1-d.csapak@proxmox.com> (raw)

otherwise one could 'inject' a latitude and longitude into the
value there. The backend still properly checks the property string
anyway.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/window/LocationEdit.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/window/LocationEdit.js b/src/window/LocationEdit.js
index f7b6c6d..4042086 100644
--- a/src/window/LocationEdit.js
+++ b/src/window/LocationEdit.js
@@ -33,6 +33,8 @@ Ext.define('Proxmox.window.LocationEdit', {
                     fieldLabel: gettext('Name'),
                     allowBlank: true,
                     emptyText: gettext('Optional'),
+                    regex: /^[^,=]+$/,
+                    regexText: gettext('No "," and "=" allowed'),
                     name: 'name',
                 },
                 {
-- 
2.47.3





                 reply	other threads:[~2026-05-19 13:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519133727.3064789-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal