[PATCH manager 1/2] ui: datacenter menu: remove 'guest resource' group

[PATCH manager 1/2] ui: datacenter menu: remove 'guest resource' group

[Dominik Csapak]

Since this is only an empty panel and the group is expanded by default,
it does not gain us anything here. instead simply drop it and show it's
children directly in the menu, saving us an empty panel and removing one
entry from the default list.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
If we really want to have that group I'd propose some things:
* collapse it by default, that way we'd at least save some space
* patch the list such that clicking the group automatically selects the
  first entry below
* add some actual content in there (e.g. rename it to just 'Hardware'
  and we could show an overview of the nodes an it's basic hardware such
  as cpu/mainboard/bios version from dmi info)

 www/manager6/dc/Config.js | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index d303c8c0..5ad8522f 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc/Config.js
@@ -397,20 +397,6 @@ Ext.define('PVE.dc.Config', {
             );
         }
 
-        if (
-            caps.mapping['Mapping.Audit'] ||
-            caps.mapping['Mapping.Use'] ||
-            caps.mapping['Mapping.Modify']
-        ) {
-            me.items.push({
-                xtype: 'panel',
-                title: gettext('Guest Resources/Hardware'),
-                iconCls: 'fa fa-sitemap',
-                itemId: 'guestresourcesandhardware',
-                expandedOnInit: true,
-            });
-        }
-
         if (
             caps.mapping['Mapping.Audit'] ||
             caps.mapping['Mapping.Use'] ||
@@ -419,7 +405,6 @@ Ext.define('PVE.dc.Config', {
             me.items.push(
                 {
                     xtype: 'container',
-                    groups: ['guestresourcesandhardware'],
                     onlineHelp: 'resource_mapping',
                     title: gettext('Resource Mappings'),
                     itemId: 'resources',
@@ -453,7 +438,6 @@ Ext.define('PVE.dc.Config', {
                 },
                 {
                     xtype: 'pveDcDirMapView',
-                    groups: ['guestresourcesandhardware'],
                     itemId: 'directories',
                     title: gettext('Directory Mappings'),
                     iconCls: 'fa fa-folder',
@@ -468,7 +452,6 @@ Ext.define('PVE.dc.Config', {
         ) {
             me.items.push({
                 xtype: 'pveCPUTypeView',
-                groups: ['guestresourcesandhardware'],
                 iconCls: 'fa fa-microchip',
                 title: gettext('Custom CPU models'),
                 itemId: 'cputypes',
-- 
2.47.3

[PATCH manager 2/2] ui: datacenter menu: cleanup item list

[Dominik Csapak]

no need to check the mapping privileges multiple times, just add them
all together. No functional change.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/dc/Config.js | 40 +++++++++++++--------------------------
 1 file changed, 13 insertions(+), 27 deletions(-)

diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index 5ad8522f..e1706636 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc/Config.js
@@ -442,36 +442,22 @@ Ext.define('PVE.dc.Config', {
                     title: gettext('Directory Mappings'),
                     iconCls: 'fa fa-folder',
                 },
+                {
+                    xtype: 'pveCPUTypeView',
+                    iconCls: 'fa fa-microchip',
+                    title: gettext('Custom CPU models'),
+                    itemId: 'cputypes',
+                },
+                {
+                    xtype: 'pmxNotificationConfigView',
+                    title: gettext('Notifications'),
+                    itemId: 'notification-targets',
+                    iconCls: 'fa fa-bell-o',
+                    baseUrl: '/cluster/notifications',
+                },
             );
         }
 
-        if (
-            caps.mapping['Mapping.Audit'] ||
-            caps.mapping['Mapping.Use'] ||
-            caps.mapping['Mapping.Modify']
-        ) {
-            me.items.push({
-                xtype: 'pveCPUTypeView',
-                iconCls: 'fa fa-microchip',
-                title: gettext('Custom CPU models'),
-                itemId: 'cputypes',
-            });
-        }
-
-        if (
-            caps.mapping['Mapping.Audit'] ||
-            caps.mapping['Mapping.Use'] ||
-            caps.mapping['Mapping.Modify']
-        ) {
-            me.items.push({
-                xtype: 'pmxNotificationConfigView',
-                title: gettext('Notifications'),
-                itemId: 'notification-targets',
-                iconCls: 'fa fa-bell-o',
-                baseUrl: '/cluster/notifications',
-            });
-        }
-
         if (caps.dc['Sys.Audit']) {
             me.items.push({
                 xtype: 'pveDcSupport',
-- 
2.47.3

applied: [PATCH manager 1/2] ui: datacenter menu: remove 'guest resource' group

[Thomas Lamprecht]

On Tue, 19 May 2026 10:20:10 +0200, Dominik Csapak wrote:
> Since this is only an empty panel and the group is expanded by default,
> it does not gain us anything here. instead simply drop it and show it's
> children directly in the menu, saving us an empty panel and removing one
> entry from the default list.

Applied, thanks!

[1/2] ui: datacenter menu: remove 'guest resource' group
      commit: 38e4e1498bb5a796ac419262811a3829f3c3a3b0
[2/2] ui: datacenter menu: cleanup item list
      commit: 7ce9f996f2679a3aaf278bfe12b874690106fc9b