From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 2/2] ui: datacenter menu: cleanup item list
Date: Tue, 19 May 2026 10:20:11 +0200 [thread overview]
Message-ID: <20260519082222.560754-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260519082222.560754-1-d.csapak@proxmox.com>
no need to check the mapping privileges multiple times, just add them
all together. No functional change.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/dc/Config.js | 40 +++++++++++++--------------------------
1 file changed, 13 insertions(+), 27 deletions(-)
diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index 5ad8522f..e1706636 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc/Config.js
@@ -442,36 +442,22 @@ Ext.define('PVE.dc.Config', {
title: gettext('Directory Mappings'),
iconCls: 'fa fa-folder',
},
+ {
+ xtype: 'pveCPUTypeView',
+ iconCls: 'fa fa-microchip',
+ title: gettext('Custom CPU models'),
+ itemId: 'cputypes',
+ },
+ {
+ xtype: 'pmxNotificationConfigView',
+ title: gettext('Notifications'),
+ itemId: 'notification-targets',
+ iconCls: 'fa fa-bell-o',
+ baseUrl: '/cluster/notifications',
+ },
);
}
- if (
- caps.mapping['Mapping.Audit'] ||
- caps.mapping['Mapping.Use'] ||
- caps.mapping['Mapping.Modify']
- ) {
- me.items.push({
- xtype: 'pveCPUTypeView',
- iconCls: 'fa fa-microchip',
- title: gettext('Custom CPU models'),
- itemId: 'cputypes',
- });
- }
-
- if (
- caps.mapping['Mapping.Audit'] ||
- caps.mapping['Mapping.Use'] ||
- caps.mapping['Mapping.Modify']
- ) {
- me.items.push({
- xtype: 'pmxNotificationConfigView',
- title: gettext('Notifications'),
- itemId: 'notification-targets',
- iconCls: 'fa fa-bell-o',
- baseUrl: '/cluster/notifications',
- });
- }
-
if (caps.dc['Sys.Audit']) {
me.items.push({
xtype: 'pveDcSupport',
--
2.47.3
next prev parent reply other threads:[~2026-05-19 8:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 8:20 [PATCH manager 1/2] ui: datacenter menu: remove 'guest resource' group Dominik Csapak
2026-05-19 8:20 ` Dominik Csapak [this message]
2026-05-19 8:50 ` applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519082222.560754-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox