public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 1/2] ui: datacenter menu: remove 'guest resource' group
Date: Tue, 19 May 2026 10:20:10 +0200	[thread overview]
Message-ID: <20260519082222.560754-1-d.csapak@proxmox.com> (raw)

Since this is only an empty panel and the group is expanded by default,
it does not gain us anything here. instead simply drop it and show it's
children directly in the menu, saving us an empty panel and removing one
entry from the default list.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
If we really want to have that group I'd propose some things:
* collapse it by default, that way we'd at least save some space
* patch the list such that clicking the group automatically selects the
  first entry below
* add some actual content in there (e.g. rename it to just 'Hardware'
  and we could show an overview of the nodes an it's basic hardware such
  as cpu/mainboard/bios version from dmi info)

 www/manager6/dc/Config.js | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index d303c8c0..5ad8522f 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc/Config.js
@@ -397,20 +397,6 @@ Ext.define('PVE.dc.Config', {
             );
         }
 
-        if (
-            caps.mapping['Mapping.Audit'] ||
-            caps.mapping['Mapping.Use'] ||
-            caps.mapping['Mapping.Modify']
-        ) {
-            me.items.push({
-                xtype: 'panel',
-                title: gettext('Guest Resources/Hardware'),
-                iconCls: 'fa fa-sitemap',
-                itemId: 'guestresourcesandhardware',
-                expandedOnInit: true,
-            });
-        }
-
         if (
             caps.mapping['Mapping.Audit'] ||
             caps.mapping['Mapping.Use'] ||
@@ -419,7 +405,6 @@ Ext.define('PVE.dc.Config', {
             me.items.push(
                 {
                     xtype: 'container',
-                    groups: ['guestresourcesandhardware'],
                     onlineHelp: 'resource_mapping',
                     title: gettext('Resource Mappings'),
                     itemId: 'resources',
@@ -453,7 +438,6 @@ Ext.define('PVE.dc.Config', {
                 },
                 {
                     xtype: 'pveDcDirMapView',
-                    groups: ['guestresourcesandhardware'],
                     itemId: 'directories',
                     title: gettext('Directory Mappings'),
                     iconCls: 'fa fa-folder',
@@ -468,7 +452,6 @@ Ext.define('PVE.dc.Config', {
         ) {
             me.items.push({
                 xtype: 'pveCPUTypeView',
-                groups: ['guestresourcesandhardware'],
                 iconCls: 'fa fa-microchip',
                 title: gettext('Custom CPU models'),
                 itemId: 'cputypes',
-- 
2.47.3





             reply	other threads:[~2026-05-19  8:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19  8:20 Dominik Csapak [this message]
2026-05-19  8:20 ` [PATCH manager 2/2] ui: datacenter menu: cleanup item list Dominik Csapak
2026-05-19  8:50 ` applied: [PATCH manager 1/2] ui: datacenter menu: remove 'guest resource' group Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519082222.560754-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal