public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: David Riley <d.riley@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: superseded: [PATCH access-control/cluster/manager/network/qemu-server 0/9] fix #7294: pool: add SDN VNets as pool members
Date: Fri, 26 Jun 2026 15:13:31 +0200	[thread overview]
Message-ID: <069ca77a-f53a-4d7e-86b1-6a8ec95e66ff@proxmox.com> (raw)
In-Reply-To: <20260611145935.147788-1-d.riley@proxmox.com>

superseded by:
https://lore.proxmox.com/pve-devel/20260626131035.112374-1-d.riley@proxmox.com/

On 6/11/26 4:59 PM, David Riley wrote:
> This series implements support for adding SDN VNets to resource pools,
> resolving #7294 [0]. This series depends on the v3 'fix #7520: sdn:
> prune orphaned ACLs and handle VNet migrations' [1].
>
> It does not, however, add zones as pool members as requested in #7294.
> Zones currently share ACL paths for managing the zone itself and
> allocating VNets within it. This makes self-service VNet management
> without also granting zone management (and its associated
> side-effects) difficult.
>
> This patch series extends the pool section in the user.cfg and
> introduces a new network property to the pool configuration which will
> hold VNet entries:
> * vnet/<zone>/<vnet>
> * vnet/<zone>/<vnet>/<vlan>
>
> The type prefix allows future extension to other network resource
> types.
>
> To prevent potential data loss from overwriting newly added VNets, a
> cluster-version check is added which ensures all nodes are running a
> version that supports this feature. Note: The hardcoded version guard
> should be updated to match the final target release when being
> applied.
>
> The existing version check helpers were moved from `qemu-server` to a
> new module within `pve-cluster` to make them available for this
> implementation, and any future developments that require gatekeeping.
> Appropriate attribution has been included for the relocated code.
> Please let me know if this organizational move aligns with current
> design preferences or additional adjustments are needed.
>
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=7294
> [1] https://lore.proxmox.com/pve-devel/20260603145523.120075-1-d.riley@proxmox.com/
>
>
> pve-manager:
>
> David Riley (3):
>    ui: replace var with let to match style guide for variable declaration
>    fix #7294: api: pool: add SDN VNets as pool members
>    fix #7294: ui: pool: add SDN VNets as pool members
>
>   PVE/API2/Pool.pm                 | 137 ++++++++++++++++++++++++++++++-
>   www/css/ext6-pve.css             |  13 +++
>   www/manager6/Utils.js            |   1 +
>   www/manager6/grid/PoolMembers.js | 130 +++++++++++++++++++++++++----
>   4 files changed, 265 insertions(+), 16 deletions(-)
>
>
> pve-access-control:
>
> David Riley (1):
>    fix #7294: acl: pool: add SDN VNets as pool members
>
>   src/PVE/AccessControl.pm  | 88 +++++++++++++++++++++++++++++++++++++--
>   src/PVE/RPCEnvironment.pm | 47 +++++++++++++++++++++
>   src/test/parser_writer.pl | 53 +++++++++++++++++++----
>   3 files changed, 176 insertions(+), 12 deletions(-)
>
>
> pve-network:
>
> David Riley (2):
>    fix #7294: sdn: register api formats for zones and vnets
>    fix #7294: sdn: vnet: update pool members on vnet migration and
>      deletion
>
>   src/PVE/Network/SDN.pm              | 15 +++++++++++++++
>   src/PVE/Network/SDN/VnetPlugin.pm   | 23 ++++++++++++++++++++---
>   src/PVE/Network/SDN/Zones/Plugin.pm | 23 ++++++++++++++++++++---
>   3 files changed, 55 insertions(+), 6 deletions(-)
>
>
> pve-cluster:
>
> David Riley (2):
>    cluster: add helpers module with version comparison functions
>    fix #7294: cluster: helpers: add cluster-wide version assertion
>
>   debian/pve-cluster.install |  1 +
>   src/PVE/Cluster/Helpers.pm | 86 ++++++++++++++++++++++++++++++++++++++
>   src/PVE/Cluster/Makefile   |  2 +-
>   3 files changed, 88 insertions(+), 1 deletion(-)
>   create mode 100644 src/PVE/Cluster/Helpers.pm
>
>
> qemu-server:
>
> David Riley (1):
>    fix #7294: helpers: use cluster-wide version helper
>
>   src/PVE/QemuMigrate.pm        |  2 +-
>   src/PVE/QemuServer/Helpers.pm | 40 +----------------------------------
>   2 files changed, 2 insertions(+), 40 deletions(-)
>
>
> Summary over all repositories:
>    15 files changed, 586 insertions(+), 75 deletions(-)
>




      parent reply	other threads:[~2026-06-26 13:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-11 14:59 [PATCH access-control/cluster/manager/network/qemu-server 0/9] fix #7294: pool: add SDN VNets as pool members David Riley
2026-06-11 14:59 ` [PATCH pve-manager 1/9] ui: replace var with let to match style guide for variable declaration David Riley
2026-06-11 14:59 ` [PATCH pve-manager 2/9] fix #7294: api: pool: add SDN VNets as pool members David Riley
2026-06-22 11:20   ` Daniel Kral
2026-06-22 13:37     ` David Riley
2026-06-24  7:32       ` Daniel Kral
2026-06-24 12:06         ` David Riley
2026-06-11 14:59 ` [PATCH pve-manager 3/9] fix #7294: ui: " David Riley
2026-06-11 14:59 ` [PATCH pve-access-control 4/9] fix #7294: acl: " David Riley
2026-06-11 14:59 ` [PATCH pve-network 5/9] fix #7294: sdn: register api formats for zones and vnets David Riley
2026-06-12 12:18   ` Gabriel Goller
2026-06-12 12:51     ` David Riley
2026-06-12 13:46       ` Gabriel Goller
2026-06-12 14:17         ` David Riley
2026-06-11 14:59 ` [PATCH pve-network 6/9] fix #7294: sdn: vnet: update pool members on vnet migration and deletion David Riley
2026-06-11 16:21   ` Gabriel Goller
2026-06-12  6:37     ` David Riley
2026-06-12  8:41       ` Gabriel Goller
2026-06-11 14:59 ` [PATCH pve-cluster 7/9] cluster: add helpers module with version comparison functions David Riley
2026-06-22  9:31   ` Daniel Kral
2026-06-22 11:44     ` David Riley
2026-06-11 14:59 ` [PATCH pve-cluster 8/9] fix #7294: cluster: helpers: add cluster-wide version assertion David Riley
2026-06-22  9:42   ` Daniel Kral
2026-06-22 11:53     ` David Riley
2026-06-11 14:59 ` [PATCH qemu-server 9/9] fix #7294: helpers: use cluster-wide version helper David Riley
2026-06-19 10:01 ` [PATCH access-control/cluster/manager/network/qemu-server 0/9] fix #7294: pool: add SDN VNets as pool members Jakob Klocker
2026-06-19 11:12   ` David Riley
2026-06-26 13:13 ` David Riley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=069ca77a-f53a-4d7e-86b1-6a8ec95e66ff@proxmox.com \
    --to=d.riley@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal