Re: [PATCH access-control/cluster/manager/network/qemu-server 0/9] fix #7294: pool: add SDN VNets as pool members

[David Riley <d.riley@proxmox.com>]

Thanks for checking it out.

On 6/19/26 12:01 PM, Jakob Klocker wrote:
> I've applied the patch and created a test user with Administration
> permissions on said pool. I've tested:
>
> - add a VNet to a pool with my root user
> - use that VNet with my test user for existing VMs & CTs
> - remove the VNet
> - add a VNet to a pool within a cluster with different PVE versions
> (9.2 & 9.1) - a error message was thrown as expected
>
> Two minor things I've noticed:
>
> - In the add dropdown under members within the pool the VNet icon is
> not grayed out like the other items. As discussed this is only visible
> when PVE is set to light mode.
Nice find, thanks I will fix this in v2.
> - when a VNet is added to a pool before the cluster is created and a
> PVE version mismatch exists (9.2 & 9.1 in my case), one PVE instance
> shows the VNet inside the pool while the other doesn't. As discussed
> checking this would take a lot of effort and I'm not sure if it's
> worth handling this edge case.

You are right that could be the case, but the chain of actions that would lead
to this are quite specific so I don't think it's worth the effort.
One would need to first create a pool with VNets and afterwards join a node
with an older version and edit the pool on that older node to overwrite the
pool configuration.

> Apart from that everything worked great. Thanks for the patch.
>
> Tested-by: Jakob Klocker <j.klocker@proxmox.com>
Will carry this over to v2.
> On 6/11/26 4:59 PM, David Riley wrote:
>> This series implements support for adding SDN VNets to resource pools,
>> resolving #7294 [0]. This series depends on the v3 'fix #7520: sdn:
>> prune orphaned ACLs and handle VNet migrations' [1].
>>
>> [...]