From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3E71C1FF142 for ; Fri, 19 Jun 2026 13:12:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5C600C68E; Fri, 19 Jun 2026 13:12:35 +0200 (CEST) Message-ID: <8e10999c-1801-4fb4-a217-5307ae88ecb8@proxmox.com> Date: Fri, 19 Jun 2026 13:12:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH access-control/cluster/manager/network/qemu-server 0/9] fix #7294: pool: add SDN VNets as pool members To: Jakob Klocker , pve-devel@lists.proxmox.com References: <20260611145935.147788-1-d.riley@proxmox.com> <0d3ca5f9-9003-4553-bc08-2daab29ba0e7@proxmox.com> Content-Language: en-US From: David Riley In-Reply-To: <0d3ca5f9-9003-4553-bc08-2daab29ba0e7@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781867546562 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.160 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VL5JKDBYGZDFRF6ZSCCZMAQPXRTSAACM X-Message-ID-Hash: VL5JKDBYGZDFRF6ZSCCZMAQPXRTSAACM X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for checking it out. On 6/19/26 12:01 PM, Jakob Klocker wrote: > I've applied the patch and created a test user with Administration > permissions on said pool. I've tested: > > - add a VNet to a pool with my root user > - use that VNet with my test user for existing VMs & CTs > - remove the VNet > - add a VNet to a pool within a cluster with different PVE versions > (9.2 & 9.1) - a error message was thrown as expected > > Two minor things I've noticed: > > - In the add dropdown under members within the pool the VNet icon is > not grayed out like the other items. As discussed this is only visible > when PVE is set to light mode. Nice find, thanks I will fix this in v2. > - when a VNet is added to a pool before the cluster is created and a > PVE version mismatch exists (9.2 & 9.1 in my case), one PVE instance > shows the VNet inside the pool while the other doesn't. As discussed > checking this would take a lot of effort and I'm not sure if it's > worth handling this edge case. You are right that could be the case, but the chain of actions that would lead to this are quite specific so I don't think it's worth the effort. One would need to first create a pool with VNets and afterwards join a node with an older version and edit the pool on that older node to overwrite the pool configuration. > Apart from that everything worked great. Thanks for the patch. > > Tested-by: Jakob Klocker Will carry this over to v2. > On 6/11/26 4:59 PM, David Riley wrote: >> This series implements support for adding SDN VNets to resource pools, >> resolving #7294 [0]. This series depends on the v3 'fix #7520: sdn: >> prune orphaned ACLs and handle VNet migrations' [1]. >> >> [...]