* [PATCH] attachment grid: fix show all parts label alignment
@ 2026-05-03 14:01 Maksim Usmanov
2026-05-04 13:00 ` Dominik Csapak
0 siblings, 1 reply; 3+ messages in thread
From: Maksim Usmanov @ 2026-05-03 14:01 UTC (permalink / raw)
To: pmg-devel; +Cc: Maksim Usmanov
Move the Show All Parts checkbox label to the right place by fixing the
boxLabelAlign typo.
Signed-off-by: Maksim Usmanov <skamasle@gmail.com>
---
js/AttachmentGrid.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/js/AttachmentGrid.js b/js/AttachmentGrid.js
index bea3e6e..ed66141 100644
--- a/js/AttachmentGrid.js
+++ b/js/AttachmentGrid.js
@@ -20,7 +20,7 @@ Ext.define('PMG.grid.AttachmentGrid', {
{
xtype: 'checkbox',
boxLabel: gettext('Show All Parts'),
- boxLabelAlgign: 'before',
+ boxLabelAlign: 'before',
listeners: {
change: function (checkBox, value) {
let store = this.up('pmgAttachmentGrid').getStore();
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] attachment grid: fix show all parts label alignment
2026-05-03 14:01 [PATCH] attachment grid: fix show all parts label alignment Maksim Usmanov
@ 2026-05-04 13:00 ` Dominik Csapak
2026-05-04 14:08 ` Maksim Usmanov
0 siblings, 1 reply; 3+ messages in thread
From: Dominik Csapak @ 2026-05-04 13:00 UTC (permalink / raw)
To: Maksim Usmanov, pmg-devel
Hi,
thanks for contributing!
the patch looks good to me, but please read our developer documentation
https://pve.proxmox.com/wiki/Developer_Documentation
especially the part at the end about the CLA.
We need the signed CLA first before applying your patches.
Thanks!
On 5/4/26 1:46 PM, Maksim Usmanov wrote:
> Move the Show All Parts checkbox label to the right place by fixing the
> boxLabelAlign typo.
>
> Signed-off-by: Maksim Usmanov <skamasle@gmail.com>
> ---
> js/AttachmentGrid.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/js/AttachmentGrid.js b/js/AttachmentGrid.js
> index bea3e6e..ed66141 100644
> --- a/js/AttachmentGrid.js
> +++ b/js/AttachmentGrid.js
> @@ -20,7 +20,7 @@ Ext.define('PMG.grid.AttachmentGrid', {
> {
> xtype: 'checkbox',
> boxLabel: gettext('Show All Parts'),
> - boxLabelAlgign: 'before',
> + boxLabelAlign: 'before',
> listeners: {
> change: function (checkBox, value) {
> let store = this.up('pmgAttachmentGrid').getStore();
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] attachment grid: fix show all parts label alignment
2026-05-04 13:00 ` Dominik Csapak
@ 2026-05-04 14:08 ` Maksim Usmanov
0 siblings, 0 replies; 3+ messages in thread
From: Maksim Usmanov @ 2026-05-04 14:08 UTC (permalink / raw)
To: Dominik Csapak; +Cc: pmg-devel
Hi,
Apologies for the oversight. I am sending the signed ICLA to
office@proxmox.com now.
I previously sent a patch that I mistakenly signed with my company
email address. I will resend it using the same email for all my
patches and include the required sign.
Apologies again, and please let me know if anything else is needed.
Best regards,
El lun, 4 may 2026 a las 15:00, Dominik Csapak
(<d.csapak@proxmox.com>) escribió:
>
> Hi,
>
> thanks for contributing!
>
> the patch looks good to me, but please read our developer documentation
> https://pve.proxmox.com/wiki/Developer_Documentation
>
> especially the part at the end about the CLA.
>
> We need the signed CLA first before applying your patches.
>
> Thanks!
>
> On 5/4/26 1:46 PM, Maksim Usmanov wrote:
> > Move the Show All Parts checkbox label to the right place by fixing the
> > boxLabelAlign typo.
> >
> > Signed-off-by: Maksim Usmanov <skamasle@gmail.com>
> > ---
> > js/AttachmentGrid.js | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/js/AttachmentGrid.js b/js/AttachmentGrid.js
> > index bea3e6e..ed66141 100644
> > --- a/js/AttachmentGrid.js
> > +++ b/js/AttachmentGrid.js
> > @@ -20,7 +20,7 @@ Ext.define('PMG.grid.AttachmentGrid', {
> > {
> > xtype: 'checkbox',
> > boxLabel: gettext('Show All Parts'),
> > - boxLabelAlgign: 'before',
> > + boxLabelAlign: 'before',
> > listeners: {
> > change: function (checkBox, value) {
> > let store = this.up('pmgAttachmentGrid').getStore();
>
>
--
----
Att: Maks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-04 14:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-03 14:01 [PATCH] attachment grid: fix show all parts label alignment Maksim Usmanov
2026-05-04 13:00 ` Dominik Csapak
2026-05-04 14:08 ` Maksim Usmanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox