From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B6C6F1FF136 for ; Mon, 04 May 2026 15:00:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A58B6216A5; Mon, 4 May 2026 15:00:16 +0200 (CEST) Message-ID: <4f732779-358b-402e-a939-7b5bfe560f2f@proxmox.com> Date: Mon, 4 May 2026 15:00:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH] attachment grid: fix show all parts label alignment To: Maksim Usmanov , pmg-devel@lists.proxmox.com References: <20260503140134.43558-1-skamasle@gmail.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260503140134.43558-1-skamasle@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777899508427 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XJ2UWOSDA4KSMCMPVJVXFXOWNPB4VCBG X-Message-ID-Hash: XJ2UWOSDA4KSMCMPVJVXFXOWNPB4VCBG X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi, thanks for contributing! the patch looks good to me, but please read our developer documentation https://pve.proxmox.com/wiki/Developer_Documentation especially the part at the end about the CLA. We need the signed CLA first before applying your patches. Thanks! On 5/4/26 1:46 PM, Maksim Usmanov wrote: > Move the Show All Parts checkbox label to the right place by fixing the > boxLabelAlign typo. > > Signed-off-by: Maksim Usmanov > --- > js/AttachmentGrid.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/js/AttachmentGrid.js b/js/AttachmentGrid.js > index bea3e6e..ed66141 100644 > --- a/js/AttachmentGrid.js > +++ b/js/AttachmentGrid.js > @@ -20,7 +20,7 @@ Ext.define('PMG.grid.AttachmentGrid', { > { > xtype: 'checkbox', > boxLabel: gettext('Show All Parts'), > - boxLabelAlgign: 'before', > + boxLabelAlign: 'before', > listeners: { > change: function (checkBox, value) { > let store = this.up('pmgAttachmentGrid').getStore();