From: Dominik Csapak <d.csapak@proxmox.com>
To: Maksim Usmanov <skamasle@gmail.com>, pmg-devel@lists.proxmox.com
Subject: Re: [PATCH] attachment grid: fix show all parts label alignment
Date: Mon, 4 May 2026 15:00:13 +0200 [thread overview]
Message-ID: <4f732779-358b-402e-a939-7b5bfe560f2f@proxmox.com> (raw)
In-Reply-To: <20260503140134.43558-1-skamasle@gmail.com>
Hi,
thanks for contributing!
the patch looks good to me, but please read our developer documentation
https://pve.proxmox.com/wiki/Developer_Documentation
especially the part at the end about the CLA.
We need the signed CLA first before applying your patches.
Thanks!
On 5/4/26 1:46 PM, Maksim Usmanov wrote:
> Move the Show All Parts checkbox label to the right place by fixing the
> boxLabelAlign typo.
>
> Signed-off-by: Maksim Usmanov <skamasle@gmail.com>
> ---
> js/AttachmentGrid.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/js/AttachmentGrid.js b/js/AttachmentGrid.js
> index bea3e6e..ed66141 100644
> --- a/js/AttachmentGrid.js
> +++ b/js/AttachmentGrid.js
> @@ -20,7 +20,7 @@ Ext.define('PMG.grid.AttachmentGrid', {
> {
> xtype: 'checkbox',
> boxLabel: gettext('Show All Parts'),
> - boxLabelAlgign: 'before',
> + boxLabelAlign: 'before',
> listeners: {
> change: function (checkBox, value) {
> let store = this.up('pmgAttachmentGrid').getStore();
next prev parent reply other threads:[~2026-05-04 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 14:01 [PATCH] attachment grid: fix show all parts label alignment Maksim Usmanov
2026-05-04 13:00 ` Dominik Csapak [this message]
2026-05-04 14:08 ` Maksim Usmanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f732779-358b-402e-a939-7b5bfe560f2f@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=skamasle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox