Re: [PATCH proxmox-backup 01/10] task tracking: count Reclaim datastore operations as writes

[Robert Obkircher <r.obkircher@proxmox.com>]

On 05.05.26 15:47, Christian Ebner wrote:
> one question regarding the accounting
>
> On 4/30/26 5:04 PM, Robert Obkircher wrote:
>> This ensures that changing a Write to a Reclaim does not break forward
>> compatibility when older versions read the counters.
>>
>> Ideally, Write operations would also be tracked separately to display
>> them as conflicts of the GarbageCollection maintenance mode, but an
>> extra field would lead to parse errors in older versions which are not
>> always propagated (for example when cloning a Datastore) and would
>> thus result in incorrect values.
>
> The following test works without issues:
>
> #[test]
> fn test_active_operation_parsing() {
>     let raw_str =
> "[{\"pid\":111,\"starttime\":111,\"active_operations\":{\"read\":1,\"write\":3,\"reclaim\":2}}]";
>    
> assert!(serde_json::from_str::<Vec<TaskOperations>>(&raw_str).is_ok());
> }
>
> So reclaim operations could be accounted for by writes and an
> optional reclaim for the time being (ignored and not written by
> older versions), allowing to switch in the future, once all versions
> are expected to handle it directly. Or am I missing something here? 

I could have sworn that I ran into parse errors at some point. Maybe I
had a modified version running without realizing it.

But yeah, it looks like we can just add the new field with a default
attribute and let the older versions remove it on every update.

> [..]