From: Christian Ebner <c.ebner@proxmox.com>
To: Robert Obkircher <r.obkircher@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup 03/10] fix #5797: www: display new GarbageCollection maintenance mode
Date: Tue, 5 May 2026 15:49:12 +0200 [thread overview]
Message-ID: <6e2157c0-0c42-45b9-97e3-9e3bfefbc78a@proxmox.com> (raw)
In-Reply-To: <20260430150607.330413-7-r.obkircher@proxmox.com>
On 4/30/26 5:05 PM, Robert Obkircher wrote:
> Display the new mode and make it selectable. This does not yet display
> the correct "conflicting tasks" count after selecting the mode.
>
Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=5797
> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
> ---
> www/Utils.js | 3 +++
> www/window/MaintenanceOptions.js | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/www/Utils.js b/www/Utils.js
> index bf4b025c7..f5c032ee2 100644
> --- a/www/Utils.js
> +++ b/www/Utils.js
> @@ -846,6 +846,9 @@ Ext.define('PBS.Utils', {
> case 'read-only':
> modeText = gettext('Read-only');
> break;
> + case 'garbage-collection':
> + modeText = gettext('Garbage Collection');
> + break;
> case 'offline':
> modeText = gettext('Offline');
> break;
> diff --git a/www/window/MaintenanceOptions.js b/www/window/MaintenanceOptions.js
> index 9a735e5e8..9228f4ee9 100644
> --- a/www/window/MaintenanceOptions.js
> +++ b/www/window/MaintenanceOptions.js
> @@ -5,6 +5,7 @@ Ext.define('PBS.form.maintenanceType', {
> comboItems: [
> ['__default__', gettext('None')],
> ['read-only', gettext('Read only')],
> + ['garbage-collection', gettext('Garbage Collection')],
> ['offline', gettext('Offline')],
> ],
> });
next prev parent reply other threads:[~2026-05-05 13:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 15:05 [RFC proxmox{,-backup} 00/13] gc maintenance mode and full datastore protection Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox 1/3] pbs-api-types: add datastore operation variant for reclaiming storage Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox 2/3] pbs-abi-types: add GarbageCollection maintenance mode Robert Obkircher
2026-05-05 13:48 ` Christian Ebner
2026-04-30 15:05 ` [PATCH proxmox 3/3] pbs-api-types: add reserved space to datastore tuning options Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 01/10] task tracking: count Reclaim datastore operations as writes Robert Obkircher
2026-05-05 13:48 ` Christian Ebner
2026-04-30 15:05 ` [PATCH proxmox-backup 02/10] datastore: open datastores with Reclaim instead of Write operation Robert Obkircher
2026-05-05 13:49 ` Christian Ebner
2026-04-30 15:05 ` [PATCH proxmox-backup 03/10] fix #5797: www: display new GarbageCollection maintenance mode Robert Obkircher
2026-05-05 13:49 ` Christian Ebner [this message]
2026-04-30 15:05 ` [PATCH proxmox-backup 04/10] www: access active operation fields by name instead of index Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 05/10] www: don't claim that all active writers are gc mode conflicts Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 06/10] chunk_store: add method to limit file system usage Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 07/10] chunk_store: check file system space before inserting new chunks Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 08/10] datastore: check file system space for blobs and group notes Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 09/10] api2: backup: check space for fixed and dynamic index files Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 10/10] fix #7254: datastore: refuse new backps when capacity is almost full Robert Obkircher
2026-05-05 13:48 ` Christian Ebner
2026-05-05 13:49 ` Christian Ebner
2026-05-05 14:06 ` [RFC proxmox{,-backup} 00/13] gc maintenance mode and full datastore protection Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e2157c0-0c42-45b9-97e3-9e3bfefbc78a@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=r.obkircher@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox