From: Robert Obkircher <r.obkircher@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 05/10] www: don't claim that all active writers are gc mode conflicts
Date: Thu, 30 Apr 2026 17:05:46 +0200 [thread overview]
Message-ID: <20260430150607.330413-9-r.obkircher@proxmox.com> (raw)
In-Reply-To: <20260430150607.330413-1-r.obkircher@proxmox.com>
Tracking the precise number of conflicts doesn't seem worth it, so
continue displaying the writer count with a different label.
Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
---
www/Utils.js | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/www/Utils.js b/www/Utils.js
index f5c032ee2..a9239b005 100644
--- a/www/Utils.js
+++ b/www/Utils.js
@@ -828,10 +828,17 @@ Ext.define('PBS.Utils', {
if (conflictingTasks > 0) {
extra += '| <i class="fa fa-spinner fa-pulse fa-fw"></i> ';
- extra += Ext.String.format(
- gettext('{0} conflicting tasks still active.'),
- conflictingTasks,
- );
+ if (type === 'garbage-collection') {
+ extra += Ext.String.format(
+ gettext('{0} active writers.'),
+ conflictingTasks,
+ );
+ } else {
+ extra += Ext.String.format(
+ gettext('{0} conflicting tasks still active.'),
+ conflictingTasks,
+ );
+ }
} else {
extra += '<i class="fa fa-check"></i>';
}
--
2.47.3
next prev parent reply other threads:[~2026-04-30 15:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 15:05 [RFC proxmox{,-backup} 00/13] gc maintenance mode and full datastore protection Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox 1/3] pbs-api-types: add datastore operation variant for reclaiming storage Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox 2/3] pbs-abi-types: add GarbageCollection maintenance mode Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox 3/3] pbs-api-types: add reserved space to datastore tuning options Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 01/10] task tracking: count Reclaim datastore operations as writes Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 02/10] datastore: open datastores with Reclaim instead of Write operation Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 03/10] fix #5797: www: display new GarbageCollection maintenance mode Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 04/10] www: access active operation fields by name instead of index Robert Obkircher
2026-04-30 15:05 ` Robert Obkircher [this message]
2026-04-30 15:05 ` [PATCH proxmox-backup 06/10] chunk_store: add method to limit file system usage Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 07/10] chunk_store: check file system space before inserting new chunks Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 08/10] datastore: check file system space for blobs and group notes Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 09/10] api2: backup: check space for fixed and dynamic index files Robert Obkircher
2026-04-30 15:05 ` [PATCH proxmox-backup 10/10] fix #7254: datastore: refuse new backps when capacity is almost full Robert Obkircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260430150607.330413-9-r.obkircher@proxmox.com \
--to=r.obkircher@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox