Re: [PATCH proxmox-backup 01/10] task tracking: count Reclaim datastore operations as writes

[Christian Ebner <c.ebner@proxmox.com>]

one question regarding the accounting

On 4/30/26 5:04 PM, Robert Obkircher wrote:
> This ensures that changing a Write to a Reclaim does not break forward
> compatibility when older versions read the counters.
> 
> Ideally, Write operations would also be tracked separately to display
> them as conflicts of the GarbageCollection maintenance mode, but an
> extra field would lead to parse errors in older versions which are not
> always propagated (for example when cloning a Datastore) and would
> thus result in incorrect values.

The following test works without issues:

#[test]
fn test_active_operation_parsing() {
     let raw_str = 
"[{\"pid\":111,\"starttime\":111,\"active_operations\":{\"read\":1,\"write\":3,\"reclaim\":2}}]";
     assert!(serde_json::from_str::<Vec<TaskOperations>>(&raw_str).is_ok());
}

So reclaim operations could be accounted for by writes and an optional 
reclaim for the time being (ignored and not written by older versions), 
allowing to switch in the future, once all versions are expected to 
handle it directly. Or am I missing something here?

> 
> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
> ---
>   pbs-datastore/src/task_tracking.rs | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/pbs-datastore/src/task_tracking.rs b/pbs-datastore/src/task_tracking.rs
> index 44a4522dc..c8833759b 100644
> --- a/pbs-datastore/src/task_tracking.rs
> +++ b/pbs-datastore/src/task_tracking.rs
> @@ -106,6 +106,7 @@ pub fn update_active_operations(
>       let mut updated_active_operations = match operation {
>           Operation::Read => ActiveOperationStats { read: 1, write: 0 },
>           Operation::Write => ActiveOperationStats { read: 0, write: 1 },
> +        Operation::Reclaim => ActiveOperationStats { read: 0, write: 1 },
>           Operation::Lookup => ActiveOperationStats { read: 0, write: 0 },
>       };
>       let mut found_entry = false;
> @@ -121,6 +122,7 @@ pub fn update_active_operations(
>                               match operation {
>                                   Operation::Read => task.active_operations.read += count,
>                                   Operation::Write => task.active_operations.write += count,
> +                                Operation::Reclaim => task.active_operations.write += count,
>                                   Operation::Lookup => (), // no IO must happen there
>                               };
>                               updated_active_operations = task.active_operations;