From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 6B1BE1FF141
	for <inbox@lore.proxmox.com>; Tue, 05 May 2026 15:49:51 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 32AF9456F;
	Tue,  5 May 2026 15:49:51 +0200 (CEST)
Message-ID: <6e2157c0-0c42-45b9-97e3-9e3bfefbc78a@proxmox.com>
Date: Tue, 5 May 2026 15:49:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Christian Ebner <c.ebner@proxmox.com>
Subject: Re: [PATCH proxmox-backup 03/10] fix #5797: www: display new
 GarbageCollection maintenance mode
To: Robert Obkircher <r.obkircher@proxmox.com>, pbs-devel@lists.proxmox.com
References: <20260430150607.330413-1-r.obkircher@proxmox.com>
 <20260430150607.330413-7-r.obkircher@proxmox.com>
Content-Language: en-US, de-DE
In-Reply-To: <20260430150607.330413-7-r.obkircher@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1777988847302
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.070 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: R7NOTBGW32CCROBSEY3AHJLVVOBYGGZ4
X-Message-ID-Hash: R7NOTBGW32CCROBSEY3AHJLVVOBYGGZ4
X-MailFrom: c.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pbs-devel-owner@lists.proxmox.com>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Subscribe: <mailto:pbs-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pbs-devel-leave@lists.proxmox.com>

On 4/30/26 5:05 PM, Robert Obkircher wrote:
> Display the new mode and make it selectable. This does not yet display
> the correct "conflicting tasks" count after selecting the mode.
> 

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=5797

> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
> ---
>   www/Utils.js                     | 3 +++
>   www/window/MaintenanceOptions.js | 1 +
>   2 files changed, 4 insertions(+)
> 
> diff --git a/www/Utils.js b/www/Utils.js
> index bf4b025c7..f5c032ee2 100644
> --- a/www/Utils.js
> +++ b/www/Utils.js
> @@ -846,6 +846,9 @@ Ext.define('PBS.Utils', {
>               case 'read-only':
>                   modeText = gettext('Read-only');
>                   break;
> +            case 'garbage-collection':
> +                modeText = gettext('Garbage Collection');
> +                break;
>               case 'offline':
>                   modeText = gettext('Offline');
>                   break;
> diff --git a/www/window/MaintenanceOptions.js b/www/window/MaintenanceOptions.js
> index 9a735e5e8..9228f4ee9 100644
> --- a/www/window/MaintenanceOptions.js
> +++ b/www/window/MaintenanceOptions.js
> @@ -5,6 +5,7 @@ Ext.define('PBS.form.maintenanceType', {
>       comboItems: [
>           ['__default__', gettext('None')],
>           ['read-only', gettext('Read only')],
> +        ['garbage-collection', gettext('Garbage Collection')],
>           ['offline', gettext('Offline')],
>       ],
>   });