Re: [PATCH proxmox-backup v3 04/15] pbs-config: use proxmox-product-config::replace_config()

[Christian Ebner <c.ebner@proxmox.com>]

On 7/6/26 2:28 PM, Robert Obkircher wrote:
> 
> On 01.07.26 16:05, Christian Ebner wrote:
>> Instead of using the pbs-config local implementation, use the product
>> general implementation, dropping the local one instead.
>>
>> Since proxmox-product-config::replace_config() requires the api- and
>> priv-user to be initialized a-priori, any calling codepath must
>> guarantee to have run proxmox-product-config::init() once.
>>
>> [..]
>>   
>> -/// Atomically write data to file owned by "root:backup" with permission "0640"
>> -///
>> -/// Only the superuser can write those files, but group 'backup' can read them.
>> -pub fn replace_backup_config<P: AsRef<std::path::Path>>(path: P, data: &[u8]) -> Result<(), Error> {
>> -    let backup_user = backup_user()?;
>> -    let mode = nix::sys::stat::Mode::from_bits_truncate(0o0640);
>> -    // set the correct owner/group/permissions while saving file
>> -    // owner(rw) = root, group(r)= backup
>> -    let options = proxmox_sys::fs::CreateOptions::new()
>> -        .perm(mode)
>> -        .owner(nix::unistd::ROOT)
>> -        .group(backup_user.gid);
>> -
>> -    proxmox_sys::fs::replace_file(path, data, options, true)?;
>> -
>> -    Ok(())
>> -}
>>
>> [..]
>>
>>   pub fn save_config(config: &SectionConfigData) -> Result<(), Error> {
>>       let raw = CONFIG.write(METRIC_SERVER_CFG_FILENAME, config)?;
>> -    crate::replace_backup_config(METRIC_SERVER_CFG_FILENAME, raw.as_bytes())
>> +    replace_config(METRIC_SERVER_CFG_FILENAME, raw.as_bytes())
>>   }
>>
>> [..]
> This changes the permissions from root:backup to backup:backup!
> 
> I think the correct function would be
> proxmox_product_config::replace_privileged_config.
> 
> (Applies to all changes in this patch)

Good catch! Will be fixed in v4!