* [PATCH proxmox-backup] fix #5971: tape: don't warn on custom MAM attribute write failures
@ 2026-07-02 12:39 Dominik Csapak
2026-07-09 7:39 ` applied: " Dietmar Maurer
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2026-07-02 12:39 UTC (permalink / raw)
To: pbs-devel
We don't actually use the MAM attributes for anything substantial, it's
just informational. This makes these warnings too noisy for drives that
don't support them, so reduce them to info level.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
pbs-tape/src/sg_tape.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pbs-tape/src/sg_tape.rs b/pbs-tape/src/sg_tape.rs
index 04914e077..3e6aac685 100644
--- a/pbs-tape/src/sg_tape.rs
+++ b/pbs-tape/src/sg_tape.rs
@@ -1192,7 +1192,7 @@ impl SgTape {
for (id, data) in attribute_list {
if let Err(err) = write_mam_attribute(&mut self.file, id, data) {
- log::warn!("could not set MAM Attribute {id:x}: {err}");
+ log::info!("could not set MAM Attribute {id:x}: {err}");
}
}
}
@@ -1201,7 +1201,7 @@ impl SgTape {
fn clear_mam_attributes(&mut self) {
for attr in [0x08_00, 0x08_01, 0x08_02, 0x08_03, 0x08_08] {
if let Err(err) = write_mam_attribute(&mut self.file, attr, b"") {
- log::warn!("could not clear MAM attribute {attr:x}: {err}");
+ log::info!("could not clear MAM attribute {attr:x}: {err}");
}
}
}
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* applied: [PATCH proxmox-backup] fix #5971: tape: don't warn on custom MAM attribute write failures
2026-07-02 12:39 [PATCH proxmox-backup] fix #5971: tape: don't warn on custom MAM attribute write failures Dominik Csapak
@ 2026-07-09 7:39 ` Dietmar Maurer
0 siblings, 0 replies; 2+ messages in thread
From: Dietmar Maurer @ 2026-07-09 7:39 UTC (permalink / raw)
To: Dominik Csapak, pbs-devel
applied
On 7/2/26 2:39 PM, Dominik Csapak wrote:
> We don't actually use the MAM attributes for anything substantial, it's
> just informational. This makes these warnings too noisy for drives that
> don't support them, so reduce them to info level.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> pbs-tape/src/sg_tape.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pbs-tape/src/sg_tape.rs b/pbs-tape/src/sg_tape.rs
> index 04914e077..3e6aac685 100644
> --- a/pbs-tape/src/sg_tape.rs
> +++ b/pbs-tape/src/sg_tape.rs
> @@ -1192,7 +1192,7 @@ impl SgTape {
>
> for (id, data) in attribute_list {
> if let Err(err) = write_mam_attribute(&mut self.file, id, data) {
> - log::warn!("could not set MAM Attribute {id:x}: {err}");
> + log::info!("could not set MAM Attribute {id:x}: {err}");
> }
> }
> }
> @@ -1201,7 +1201,7 @@ impl SgTape {
> fn clear_mam_attributes(&mut self) {
> for attr in [0x08_00, 0x08_01, 0x08_02, 0x08_03, 0x08_08] {
> if let Err(err) = write_mam_attribute(&mut self.file, attr, b"") {
> - log::warn!("could not clear MAM attribute {attr:x}: {err}");
> + log::info!("could not clear MAM attribute {attr:x}: {err}");
> }
> }
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-09 7:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-02 12:39 [PATCH proxmox-backup] fix #5971: tape: don't warn on custom MAM attribute write failures Dominik Csapak
2026-07-09 7:39 ` applied: " Dietmar Maurer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox