From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 204C31FF135 for ; Thu, 02 Jul 2026 14:39:19 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3F0FB213F9; Thu, 02 Jul 2026 14:39:18 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup] fix #5971: tape: don't warn on custom MAM attribute write failures Date: Thu, 2 Jul 2026 14:39:04 +0200 Message-ID: <20260702123910.3975440-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YPKWX5THBP6DH4EK5JL22OFW6645ZYED X-Message-ID-Hash: YPKWX5THBP6DH4EK5JL22OFW6645ZYED X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We don't actually use the MAM attributes for anything substantial, it's just informational. This makes these warnings too noisy for drives that don't support them, so reduce them to info level. Signed-off-by: Dominik Csapak --- pbs-tape/src/sg_tape.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pbs-tape/src/sg_tape.rs b/pbs-tape/src/sg_tape.rs index 04914e077..3e6aac685 100644 --- a/pbs-tape/src/sg_tape.rs +++ b/pbs-tape/src/sg_tape.rs @@ -1192,7 +1192,7 @@ impl SgTape { for (id, data) in attribute_list { if let Err(err) = write_mam_attribute(&mut self.file, id, data) { - log::warn!("could not set MAM Attribute {id:x}: {err}"); + log::info!("could not set MAM Attribute {id:x}: {err}"); } } } @@ -1201,7 +1201,7 @@ impl SgTape { fn clear_mam_attributes(&mut self) { for attr in [0x08_00, 0x08_01, 0x08_02, 0x08_03, 0x08_08] { if let Err(err) = write_mam_attribute(&mut self.file, attr, b"") { - log::warn!("could not clear MAM attribute {attr:x}: {err}"); + log::info!("could not clear MAM attribute {attr:x}: {err}"); } } } -- 2.47.3