public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: applied: [PATCH proxmox-backup] fix #5971: tape: don't warn on custom MAM attribute write failures
Date: Thu, 9 Jul 2026 09:39:14 +0200	[thread overview]
Message-ID: <4f303ee8-64aa-4cff-9bed-102ec12db005@proxmox.com> (raw)
In-Reply-To: <20260702123910.3975440-1-d.csapak@proxmox.com>

applied

On 7/2/26 2:39 PM, Dominik Csapak wrote:
> We don't actually use the MAM attributes for anything substantial, it's
> just informational. This makes these warnings too noisy for drives that
> don't support them, so reduce them to info level.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>   pbs-tape/src/sg_tape.rs | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pbs-tape/src/sg_tape.rs b/pbs-tape/src/sg_tape.rs
> index 04914e077..3e6aac685 100644
> --- a/pbs-tape/src/sg_tape.rs
> +++ b/pbs-tape/src/sg_tape.rs
> @@ -1192,7 +1192,7 @@ impl SgTape {
>   
>           for (id, data) in attribute_list {
>               if let Err(err) = write_mam_attribute(&mut self.file, id, data) {
> -                log::warn!("could not set MAM Attribute {id:x}: {err}");
> +                log::info!("could not set MAM Attribute {id:x}: {err}");
>               }
>           }
>       }
> @@ -1201,7 +1201,7 @@ impl SgTape {
>       fn clear_mam_attributes(&mut self) {
>           for attr in [0x08_00, 0x08_01, 0x08_02, 0x08_03, 0x08_08] {
>               if let Err(err) = write_mam_attribute(&mut self.file, attr, b"") {
> -                log::warn!("could not clear MAM attribute {attr:x}: {err}");
> +                log::info!("could not clear MAM attribute {attr:x}: {err}");
>               }
>           }
>       }




      reply	other threads:[~2026-07-09  7:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02 12:39 [PATCH proxmox-backup] fix #5971: tape: don't warn on custom MAM attribute write failures Dominik Csapak
2026-07-09  7:39 ` Dietmar Maurer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f303ee8-64aa-4cff-9bed-102ec12db005@proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal