[PATCH proxmox-backup] ui: datastore content: always reload after namespace move

[PATCH proxmox-backup] ui: datastore content: always reload after namespace move

[Dominik Csapak]

After a partial namespace move it could happen that some groups that
were in the current were actually moved, so reload the view and
namespace selector in any case.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
NOTE: this conflicts with my RFC for ns moving from parent:
https://lore.proxmox.com/pbs-devel/20260428111822.2471005-1-d.csapak@proxmox.com/T/#u

but that patch would get a normal version anyway when we decide how to
handle the cases, so this patch could get applied already.

 www/datastore/Content.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index b1e1f66cb..2c3aa6861 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -690,6 +690,11 @@ Ext.define('PBS.DataStoreContent', {
                         selector?.store?.load({
                             callback: () => selector.setValue(newNs),
                         });
+                    } else {
+                        // if we ran into an error, keep the current view, but
+                        // reload it and the namespace selector in case a new namespace was created
+                        view.down('pbsNamespaceSelector')?.store?.load();
+                        me.reload();
                     }
                 },
             });
-- 
2.47.3

Re: [PATCH proxmox-backup] ui: datastore content: always reload after namespace move

[Dominik Csapak]

On 4/28/26 2:22 PM, Dominik Csapak wrote:
> After a partial namespace move it could happen that some groups that
> were in the current were actually moved, so reload the view and
> namespace selector in any case.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> NOTE: this conflicts with my RFC for ns moving from parent:
> https://lore.proxmox.com/pbs-devel/20260428111822.2471005-1-d.csapak@proxmox.com/T/#u
> 
> but that patch would get a normal version anyway when we decide how to
> handle the cases, so this patch could get applied already.

the comment is actually wrong, it conflicts with my other patch i sent
today : 
https://lore.proxmox.com/pbs-devel/1caf3dc4-cc7e-4560-b37d-642cbd89a533@proxmox.com/T/#t

i'd send either one rebased once one of them is applied
> 
>   www/datastore/Content.js | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/www/datastore/Content.js b/www/datastore/Content.js
> index b1e1f66cb..2c3aa6861 100644
> --- a/www/datastore/Content.js
> +++ b/www/datastore/Content.js
> @@ -690,6 +690,11 @@ Ext.define('PBS.DataStoreContent', {
>                           selector?.store?.load({
>                               callback: () => selector.setValue(newNs),
>                           });
> +                    } else {
> +                        // if we ran into an error, keep the current view, but
> +                        // reload it and the namespace selector in case a new namespace was created
> +                        view.down('pbsNamespaceSelector')?.store?.load();
> +                        me.reload();
>                       }
>                   },
>               });

superseded: [PATCH proxmox-backup] ui: datastore content: always reload after namespace move

[Dominik Csapak]

superseded by v2:

https://lore.proxmox.com/pbs-devel/20260428131722.3386349-1-d.csapak@proxmox.com/T/#u